WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 16 months ago

#52795 closed enhancement (fixed)

Wrong DocBlock for unregister_block_style

Reported by: kraftner's profile kraftner Owned by: davidbaumwald's profile davidbaumwald
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.8
Component: General Keywords: has-patch
Focuses: docs Cc:

Description

Currently the DocBlock for the $block_style_name parameter of unregister_block_style() is documented as being an array while in fact it needs to be a string since it passes the parameter on to WP_Block_Styles_Registry::unregister() which takes a string.

Change History (6)

This ticket was mentioned in ​PR #1093 on ​WordPress/wordpress-develop by ​kraftner.
5 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/52795

#2 @kraftner
5 years ago

I've added a PR that fixes this.

#3 @davidbaumwald
5 years ago

  • Owner set to davidbaumwald
  • Status changed from new to assigned

#4 @davidbaumwald
5 years ago

  • Milestone changed from Awaiting Review to 5.8

#5 @davidbaumwald
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 50528:

Docs: Correct unregister_block_style @param for $block_name.

In unregister_block_style, the $block_name parameter was documented as an array. This change corrects the type to string, as that's what is expected in WP_Block_Styles_Registry->unregister.

Props kraftner.
Fixes #52795.

​@SergeyBiryukov commented on ​PR #1093:
16 months ago #6

Thanks for the PR! This was merged in r50528.

Note: See TracTickets for help on using tickets.