WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#52878 closed defect (bug) (fixed)

Edit.php clear div closed incorrectly

Reported by: pavelvisualcomposer's profile pavelvisualcomposer Owned by: audrasjb's profile audrasjb
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.6
Component: Posts, Post Types Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

div tag closed wrongly

​https://github.com/pavelthq/wordpress-develop/blob/master/src/wp-admin/edit.php#L485

Attachments (1)

52878.patch​ (659 bytes) - added by akabarikalpesh 4 years ago.
removed extra "/" in div. please check and let me know if any changes. :)

Download all attachments as: .zip

Change History (9)

#2 @audrasjb
4 years ago

  • Component changed from General to Posts, Post Types
  • Milestone changed from Awaiting Review to 5.8
  • Owner set to audrasjb
  • Severity changed from minor to normal
  • Status changed from new to accepted
  • Version trunk deleted

Hello and welcome to WordPress Trac @pavelvisualcomposer,

The issue and the patch sound legit to me. Moving to next milestone.

#3 @sabernhardt
4 years ago

Thanks for the report and patch!

I searched for other divs like that and found one more in users.php.

@akabarikalpesh
4 years ago

removed extra "/" in div. please check and let me know if any changes. :)

#4 @akabarikalpesh
4 years ago

  • Keywords needs-testing added

#5 @audrasjb
4 years ago

  • Keywords commit added; needs-testing removed

Patch looks good to me and applies cleanly.
Marking this as ready for commit.

#6 @SergeyBiryukov
4 years ago

  • Version set to 5.6

Introduced in [49178] / #49246.

#7 @davidbaumwald
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 50582:

Posts, Post Types: Remove / from non-self-closing "clear" div tags.

In [49178], self-closing br tags were switched to non-self-closing div elements for "clearing" purposes, but the self-closing "/" remained in place. This fix removes the unnecessary slash.

Props pavelvisualcomposer, audrasjb, sabernhardt, akabarikalpesh, SergeyBiryukov.
Fixes #52878.

Note: See TracTickets for help on using tickets.