Context Navigation

← Previous Ticket
Next Ticket →

#52878 closed defect (bug) (fixed)

Edit.php clear div closed incorrectly

Reported by:	pavelvisualcomposer	Owned by:	audrasjb
Priority:	normal	Milestone:	5.8
Component:	Posts, Post Types	Version:	5.6
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:	coding-standards

Description

div tag closed wrongly

https://github.com/pavelthq/wordpress-develop/blob/master/src/wp-admin/edit.php#L485

Attachments (1)

52878.patch (659 bytes ) - added by akabarikalpesh 5 years ago.: removed extra "/" in div. please check and let me know if any changes. :)

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in PR #1110 on WordPress/wordpress-develop by pavelthq.

5 years ago #1

https://core.trac.wordpress.org/ticket/52878#ticket

#2 @audrasjb
5 years ago

Component General → Posts, Post Types
Milestone Awaiting Review → 5.8
Owner set to audrasjb
Severity minor → normal
Status new → accepted
Version trunk

Hello and welcome to WordPress Trac @pavelvisualcomposer,

The issue and the patch sound legit to me. Moving to next milestone.

#3 @sabernhardt
5 years ago

Thanks for the report and patch!

I searched for other divs like that and found one more in users.php.

@akabarikalpesh
5 years ago

Attachment 52878.patch added

removed extra "/" in div. please check and let me know if any changes. :)

#4 @akabarikalpesh
5 years ago

Keywords needs-testing added

#5 @audrasjb
5 years ago

Keywords commit added; needs-testing removed

Patch looks good to me and applies cleanly.
Marking this as ready for commit.

#6 @SergeyBiryukov
5 years ago

Version → 5.6

Introduced in [49178] / #49246.

#7 @davidbaumwald
5 years ago

Resolution → fixed
Status accepted → closed

In 50582:

Posts, Post Types: Remove / from non-self-closing "clear" div tags.

In [49178], self-closing br tags were switched to non-self-closing div elements for "clearing" purposes, but the self-closing "/" remained in place. This fix removes the unnecessary slash.

Props pavelvisualcomposer, audrasjb, sabernhardt, akabarikalpesh, SergeyBiryukov.
Fixes #52878.

dream-encode commented on PR #1110:

5 years ago #8

Fixed in https://core.trac.wordpress.org/changeset/50582

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#52878 closed defect (bug) (fixed)

Edit.php clear div closed incorrectly

Description

Attachments (1)

Change History (9)

This ticket was mentioned in ​PR #1110 on ​WordPress/wordpress-develop by ​pavelthq. 5 years ago #1

#2 @audrasjb 5 years ago

#3 @sabernhardt 5 years ago

@akabarikalpesh 5 years ago

#4 @akabarikalpesh 5 years ago

#5 @audrasjb 5 years ago

#6 @SergeyBiryukov 5 years ago

#7 @davidbaumwald 5 years ago

​dream-encode commented on ​PR #1110: 5 years ago #8