Privacy: print screen reader text message

[mukesh27]

Print screen reader text message for privacy_policy_guide() function.

Trac ticket: https://core.trac.wordpress.org/ticket/52891

[carike]

Could you please expand on this?
I'm not sure what this ticket does, or why?
I assume this is to improve accessibility, but not sure what was wrong?

[SergeyBiryukov]

Thanks for the ticket and the patch!

Moving to 5.7.1, as this was introduced in [50161] / #49264.

Just noting that echo sprintf() can be replaced with just printf().

[SergeyBiryukov]

Replying to carike:

I assume this is to improve accessibility, but not sure what was wrong?

The sprintf() function was erroneously used instead of printf(), so the screen reader text is not actually printed.

[sabernhardt]

After switching to printf, screen readers would speak both the visible text plus the intended screen reader text:
"Copy suggested policy text to clipboard Copy suggested policy text from WordPress. button"

One way to fix the redundancy is wrapping the visible text with <span aria-hidden="true"></span>:

	<button type="button" class="privacy-text-copy button">
		<span aria-hidden="true"><?php _e( 'Copy suggested policy text to clipboard' ); ?></span>
		<span class="screen-reader-text">
			<?php
			/* translators: %s: Plugin name. */
			printf( __( 'Copy suggested policy text from %s.' ), $plugin_name );
			?>
		</span>
	</button>

Trac ticket: https://core.trac.wordpress.org/ticket/52891

[mukesh27]

​PR #1119 patch updated.

[davidbaumwald]

In 50585:

Privacy: Print screen reader text for the "Copy suggested policy text..." action button.

This change switches out sprintf for printf on the "Copy suggested policy text from..." button screen reader text. Also, wrap the actual button text in a <span aria-hidden="true"> to prevent both the button text and the screen reader text from being spoken.

Props mukesh27, SergeyBiryukov, sabernhardt.
Fixes #52891.

[SergeyBiryukov]

Reopening for backporting to the 5.7 branch.

[davidbaumwald]

Adding dev-feedback for a secondary review prior to backporting.

[desrosj]

Looks good for backport, @davidbaumwald!

[davidbaumwald]

In 50609:

Privacy: Print screen reader text for the "Copy suggested policy text..." action button.

This change switches out sprintf for printf on the "Copy suggested policy text from..." button screen reader text. Also, wrap the actual button text in a <span aria-hidden="true"> to prevent both the button text and the screen reader text from being spoken.

Props mukesh27, SergeyBiryukov, sabernhardt, desrosj.
Merges [50585] to the 5.7 branch.
Fixes #52891.

[desrosj]

In 51431:

Privacy: Ensure the copy button actually copies the suggested privacy policy text.

Follow up to [50609].

Props walbo, SergeyBiryukov.
Fixes #53652. See #52891.

[desrosj]

In 51433:

Privacy: Ensure the copy button actually copies the suggested privacy policy text.

Follow up to [50609].

Props walbo, SergeyBiryukov.
Merges [51431] to the 5.8 branch.
Fixes #53652. See #52891.