WordPress.org

Make WordPress Core

Opened 2 weeks ago

Last modified 5 hours ago

#53323 assigned enhancement

Place Hello Dolly in containing folder

Reported by: afragen Owned by: afragen
Milestone: 5.8 Priority: normal
Severity: normal Version: trunk
Component: Upgrade/Install Keywords: has-patch needs-testing
Focuses: Cc:

Description

Currently Hello Dolly is installed as a single file plugin during a WP core installation. According to Plugin Handbook Best Practices, plugins should be in containing folders. https://developer.wordpress.org/plugins/plugin-basics/best-practices/#folder-structure

This is a simple PR to fix this issue with Hello Dolly. Having this means that things like r51064 are not necessary.

Related #49338

Change History (16)

This ticket was mentioned in PR #1330 on WordPress/wordpress-develop by afragen.


2 weeks ago

Currently Hello Dolly is installed as a single file plugin during a WP core installation. According to Plugin Handbook Best Practices, plugins should be in containing folders. https://developer.wordpress.org/plugins/plugin-basics/best-practices/#folder-structure

This is a simple PR to fix this issue with Hello Dolly. Having this means that things like r51064 are not necessary.

Related #49338

Trac ticket: https://core.trac.wordpress.org/ticket/53323

This ticket was mentioned in Slack in #core by afragen. View the logs.


2 weeks ago

#3 @afragen
2 weeks ago

  • Keywords needs-unit-tests added

Looks like it needs an update to some of the unit tests.

#4 @afragen
2 weeks ago

  • Keywords needs-unit-tests removed

Tests updated

#5 @SergeyBiryukov
2 weeks ago

Perhaps we should also add hello.php to the $_old_files array in wp-admin/includes/update-core.php, so that those who upgrade from previous WordPress versions don't get two copies of the plugin.

Last edited 2 weeks ago by SergeyBiryukov (previous) (diff)

#6 @afragen
2 weeks ago

I can do that tomorrow.

#7 @afragen
13 days ago

  • Owner set to afragen

@SergeyBiryukov all recommendations have been added to PR, tests pass 😉

This ticket was mentioned in Slack in #core-auto-updates by afragen. View the logs.


8 days ago

#9 @afragen
8 days ago

  • Milestone changed from Awaiting Review to 5.9

#10 @afragen
7 days ago

This may actually require the version of Hello Dolly in the plugin repository to be updated to add the header

Text Domain: hello-dolly

This ticket was mentioned in Slack in #core by afragen. View the logs.


7 days ago

#12 @afragen
7 days ago

  • Keywords needs-testing added

In testing, if there is a plugin at hello-dolly/hello.php, updating core, using WP Beta Tester, does not install a new version of hello.php. This should mean that if a user has the older hello.php installed, an update will not over-write the plugin.

Might need more testing, but I think Hello Dolly is only installed in a new installation, not in a update. Therefore anyone who has Hello Dolly installed wouldn't see a change until they updated it, where the plugin repository would install a version in a containing folder.

Last edited 7 days ago by afragen (previous) (diff)

#13 @afragen
7 days ago

  • Milestone changed from 5.9 to 5.8

This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.


5 hours ago

This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.


5 hours ago

This ticket was mentioned in Slack in #core-test by pbearne. View the logs.


5 hours ago

Note: See TracTickets for help on using tickets.