WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#53378 closed defect (bug) (fixed)

Two regressions in the UI color control

Reported by: oandregal Owned by:
Priority: normal Milestone: 5.8
Component: Editor Version: 5.8
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

There's a couple of regressions related to the UI control control in the block editor:

  • themes can no longer pass an empty array to disable the feature
  • the legacy settings.color setting in the core/block-editor client store didn't have the proper value

Related https://core.trac.wordpress.org/ticket/53175

Change History (7)

This ticket was mentioned in ​PR #1363 on ​WordPress/wordpress-develop by ​nosolosw.
5 years ago #1

Fixes https://core.trac.wordpress.org/ticket/53378

We found a couple of regressions with colors:

  • themes could no longer pass an empty array to disable the feature
  • the legacy settings.color setting in the core/block-editor store didn't have the proper value

These have been fixed in the plugin with this PR ​https://github.com/WordPress/gutenberg/pull/32358

props @jorgefilipecosta

#2 @desrosj
5 years ago

  • Milestone Awaiting Review → 5.8

Moving to 5.8 for visibility.

​nosolosw commented on ​PR #1363:
5 years ago #3

Noting this one may need updating with the changes at ​https://github.com/WordPress/gutenberg/pull/32622

#5 @oandregal
5 years ago

This is going to be closed when https://core.trac.wordpress.org/ticket/53397 lands, as the changes necessary to fix it are part of that backport.

#6 @desrosj
5 years ago

  • Resolution → fixed
  • Status new → closed

#53397 is now fixed. @nosolosw if you could, please just double check trunk when you have a chance to confirm.

#7 @oandregal
5 years ago

Just tested it and can confirm this is fixed.

Note: See TracTickets for help on using tickets.