Twenty Twenty-One: Add privacy policy link to footer

[ryelle]

If you have a privacy policy set, the page should be linked to from the footer of the site. The other bundled themes add this link using the_privacy_policy_link, but Twenty Twenty-One does not.

In #43715, when the link was added to Twenty Seventeen and earlier, it was dropped next to "Powered by WordPress". I think the same could be done for Twenty Twenty-One.

[kapilpaul]

Hi,

The patch is added to this 53446. Both Twenty Twenty and Twenty Twenty One theme is covered.

Screenshots:

​http://snappyimages.nextwavesrl.netdna-cdn.com/img/be51b146523d8c89e82bc47bbcc7fb8c.png

​http://snappyimages.nextwavesrl.netdna-cdn.com/img/aea12866603103dc4fa22e73c210e493.png

[kapilpaul]

Created patch.

[audrasjb]

@kapilpaul the patch looks good at a glance. It would be nice to provide some screenshots.
Adding needs-testing keyword.

[kapilpaul]

Replying to audrasjb:

@kapilpaul the patch looks good at a glance. It would be nice to provide some screenshots.
Adding needs-testing keyword.

Hi, added screenshots in my previous comment.

[sabernhardt]

mobile layout, at 320px

[sabernhardt]

desktop layout, at 822px breakpoint

[sabernhardt]

desktop layout, at 1200px

[sabernhardt]

Changes in 53445.1.diff​:

• adding the privacy policy link within the footer.php template instead of a new template part (as @audrasjb suggested on Slack)
• putting the link inside a new div instead of inside the powered-by container, so the WordPress link text does not wrap under Privacy Policy
• making a few small margin edits

Note: At 822px and a bit wider, the flex layout can push each of the three footer elements to a second line. This was already possible with long site names and/or long translations, but it would be more common with the link there and I do not have a good alternative for Twenty Twenty-One. (I tried flex-wrap here but did not like that.)

[justinahinon]

Test report

Environment

• WordPress: 5.9-alpha-51272-src
• PHP version: 7.4.23
• OS: 12.0 Beta
• Browser: Firefox Developer Edition 94.0b9
• Theme: Twenty Twenty One
• Plugins: no

Test results

The patch 53445.1 applies correctly, and correctly adds the privacy policy page to the site footer.
But there are still some issues with the position of the link, that tends to sit just next to the site link on larger screens (+836px); see ​https://cln.sh/Ezo6KP.

[hellofromTonya]

@justinahinon found a positioning issue:

But there are still some issues with the position of the link, that tends to sit just next to the site link on larger screens (+836px); see ​https://cln.sh/Ezo6KP.

@justinahinon @audrasjb is this something to resolve before committing the patch?

[justinahinon]

@hellofromTonya I've just tested again against the latest trunk, and the link position is fine (​https://cln.sh/sc3RPZ).

It is probably good to go.

[audrasjb]

Thanks for testing and confirming @justinahinon ✌️

[hellofromTonya]

Assigning to me for commit.

[hellofromTonya]

In 52082:

Twenty Twenty-One: Add privacy policy link to footer.

If a privacy policy is set, the page links to the footer of the site. As done in the other bundled themes, this link is added using the_privacy_policy_link().

Follow-up to [49216].

Props ryelle, desrosj, kapilpaul, sabernhardt, audrasjb, justinahinon.
Fixes #53445.

[hellofromTonya]

Thank you everyone for contributing! The patch is committed and will ship with 5.9.

[sabernhardt]

Mention in a "Bundled Themes changes" dev note, along with the change for Twenty Twenty (ticket:53446#comment:14)

[sabernhardt]

Bundled themes update note:
​https://make.wordpress.org/core/2022/01/05/bundled-theme-updates-with-wordpress-5-9/