Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#53445 closed enhancement (fixed)

Twenty Twenty-One: Add privacy policy link to footer

Reported by: ryelle's profile ryelle Owned by: hellofromtonya's profile hellofromTonya
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots needs-docs has-dev-note
Focuses: privacy Cc:

Description

If you have a privacy policy set, the page should be linked to from the footer of the site. The other bundled themes add this link using the_privacy_policy_link, but Twenty Twenty-One does not.

In #43715, when the link was added to Twenty Seventeen and earlier, it was dropped next to "Powered by WordPress". I think the same could be done for Twenty Twenty-One.

Attachments (5)

53445.diff (5.0 KB) - added by kapilpaul 3 years ago.
Created patch.
53445.1.diff (161.4 KB) - added by sabernhardt 2 years ago.
2021-privacy-320px.png (5.9 KB) - added by sabernhardt 2 years ago.
mobile layout, at 320px
2021-privacy-822px.png (7.5 KB) - added by sabernhardt 2 years ago.
desktop layout, at 822px breakpoint
2021-privacy-1200px.png (7.4 KB) - added by sabernhardt 2 years ago.
desktop layout, at 1200px

Download all attachments as: .zip

Change History (25)

#1 @desrosj
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.9

#2 @kapilpaul
3 years ago

  • Keywords has-patch added; needs-patch removed
Last edited 2 years ago by kapilpaul (previous) (diff)

@kapilpaul
3 years ago

Created patch.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

#4 follow-up: @audrasjb
2 years ago

  • Focuses privacy added
  • Keywords needs-testing needs-screenshots added

@kapilpaul the patch looks good at a glance. It would be nice to provide some screenshots.
Adding needs-testing keyword.

#5 in reply to: ↑ 4 @kapilpaul
2 years ago

Replying to audrasjb:

@kapilpaul the patch looks good at a glance. It would be nice to provide some screenshots.
Adding needs-testing keyword.

Hi, added screenshots in my previous comment.

@sabernhardt
2 years ago

@sabernhardt
2 years ago

mobile layout, at 320px

@sabernhardt
2 years ago

desktop layout, at 822px breakpoint

@sabernhardt
2 years ago

desktop layout, at 1200px

#6 @sabernhardt
2 years ago

Changes in 53445.1.diff:

  • adding the privacy policy link within the footer.php template instead of a new template part (as @audrasjb suggested on Slack)
  • putting the link inside a new div instead of inside the powered-by container, so the WordPress link text does not wrap under Privacy Policy
  • making a few small margin edits

Note: At 822px and a bit wider, the flex layout can push each of the three footer elements to a second line. This was already possible with long site names and/or long translations, but it would be more common with the link there and I do not have a good alternative for Twenty Twenty-One. (I tried flex-wrap here but did not like that.)

Last edited 2 years ago by sabernhardt (previous) (diff)

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

#8 @audrasjb
2 years ago

  • Keywords has-screenshots added; needs-testing needs-screenshots removed

This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by chaion07. View the logs.


2 years ago

This ticket was mentioned in Slack in #core-test by boniu91. View the logs.


2 years ago

#12 @justinahinon
2 years ago

Test report

Environment

  • WordPress: 5.9-alpha-51272-src
  • PHP version: 7.4.23
  • OS: 12.0 Beta
  • Browser: Firefox Developer Edition 94.0b9
  • Theme: Twenty Twenty One
  • Plugins: no

Test results

The patch 53445.1 applies correctly, and correctly adds the privacy policy page to the site footer.
But there are still some issues with the position of the link, that tends to sit just next to the site link on larger screens (+836px); see https://cln.sh/Ezo6KP.

#13 @hellofromTonya
2 years ago

@justinahinon found a positioning issue:

But there are still some issues with the position of the link, that tends to sit just next to the site link on larger screens (+836px); see https://cln.sh/Ezo6KP.

@justinahinon @audrasjb is this something to resolve before committing the patch?

#14 @justinahinon
2 years ago

@hellofromTonya I've just tested again against the latest trunk, and the link position is fine (https://cln.sh/sc3RPZ).

It is probably good to go.

#15 @audrasjb
2 years ago

  • Keywords commit added

Thanks for testing and confirming @justinahinon ✌️

#16 @hellofromTonya
2 years ago

  • Owner set to hellofromTonya
  • Status changed from new to reviewing

Assigning to me for commit.

#17 @hellofromTonya
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52082:

Twenty Twenty-One: Add privacy policy link to footer.

If a privacy policy is set, the page links to the footer of the site. As done in the other bundled themes, this link is added using the_privacy_policy_link().

Follow-up to [49216].

Props ryelle, desrosj, kapilpaul, sabernhardt, audrasjb, justinahinon.
Fixes #53445.

#18 @hellofromTonya
2 years ago

Thank you everyone for contributing! The patch is committed and will ship with 5.9.

#19 @sabernhardt
2 years ago

  • Keywords needs-docs needs-dev-note added; commit removed

Mention in a "Bundled Themes changes" dev note, along with the change for Twenty Twenty (ticket:53446#comment:14)

#20 @sabernhardt
2 years ago

  • Keywords has-dev-note added; needs-dev-note removed
Note: See TracTickets for help on using tickets.