WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#53672 closed defect (bug) (fixed)

JS error thrown in Media Library when infinite scrolling re-enabled

Reported by: wildworks's profile wildworks Owned by: joedolson's profile joedolson
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.8
Component: Media Keywords: has-patch commit fixed-major dev-reviewed
Focuses: javascript Cc:

Description

this.updateLoadMoreView(); is called without checking whether infinite scrolling is enabled. Needs to be wrapped in a check for infiniteScrolling.

Reported by @wildworks on #50105; issue broken out for tracking.

Patch forthcoming.

Attachments (1)

53672.diff​ (509 bytes) - added by joedolson 3 years ago.
Fix JS error.

Download all attachments as: .zip

Change History (6)

@joedolson
3 years ago

Fix JS error.

#1 @joedolson
3 years ago

  • Keywords has-patch commit added; needs-patch removed

#2 @joedolson
3 years ago

  • Owner set to joedolson
  • Resolution set to fixed
  • Status changed from new to closed

In 51440:

Media: Fix JS error in Media Library when infinite scroll enabled.

Wrap call to this.updateLoadMoreView() is wrapped in a check that infinite scroll is disabled to prevent JS errors.

Props wildworks.
Fixes #53672.

This ticket was mentioned in ​Slack in #core-media by desrosj. ​View the logs.
3 years ago

#4 @desrosj
3 years ago

  • Keywords fixed-major dev-reviewed added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport to 5.8.

#5 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51441:

Media: Fix JS error in Media Library when infinite scroll enabled.

Wrap call to this.updateLoadMoreView() is wrapped in a check that infinite scroll is disabled to prevent JS errors.

Props wildworks, joedolson.
Merges [51440] to the 5.8 branch.
Fixes #53672.

Note: See TracTickets for help on using tickets.