Make WordPress Core

Opened 3 years ago

Closed 13 months ago

Last modified 13 months ago

#54012 closed defect (bug) (fixed)

Multisite: SIte Title is not checked even if it shows that it is required

Reported by: alucard001's profile alucard001 Owned by: jorbin's profile jorbin
Milestone: 6.3 Priority: normal
Severity: normal Version: 5.8
Component: Networks and Sites Keywords: has-patch
Focuses: administration Cc:

Description

In http://localhost/wp-admin/network/site-new.php, if we input everything except Site Title, which shows it is required, the process of adding is still going well.

It is because in wp_prepare_site_data() function, the $allowed_data_fields did not contain field "title". You will see that in wp_normalize_site_data(), it contains "title", but later in wp_validate_site_data action, $data did not contain "title", and there is actually no checking on this field.

Please add this title validation back to the process.

Thank you

Change History (6)

#1 @sabernhardt
3 years ago

  • Component changed from Administration to Networks and Sites
  • Focuses administration added

This ticket was mentioned in PR #4477 on WordPress/wordpress-develop by @ideag.


13 months ago
#2

  • Keywords has-patch added

#54012 adds backend validation for a field that is marked as required in the UI (Site Title in Add New Site screen)

Trac ticket: https://core.trac.wordpress.org/ticket/54012

#3 @jorbin
13 months ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 55894:

Multisite: Require a site title when a site is created

The UI for adding a site says that title is required, however the actual code wasn't requiring it.

Props ideag.
Fixes #54012.

#5 @kebbet
13 months ago

@jorbin Please update the milestone to 6.3. Thanks!

#6 @jorbin
13 months ago

  • Milestone changed from Awaiting Review to 6.3
Note: See TracTickets for help on using tickets.