WordPress.org

Make WordPress Core

Opened 6 days ago

Closed 44 hours ago

Last modified 43 hours ago

#54110 closed enhancement (fixed)

Translation note requested for a block to avoid mistranslations.

Reported by: NekoJonez Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8
Component: Widgets Keywords: good-first-bug has-patch
Focuses: ui Cc:

Description

https://build.trac.wordpress.org/browser/trunk/wp-includes/widgets/class-wp-widget-block.php?marks=205#L205

Could a translator note be added on this string? Since it's a bit unclear if the string: "Block HTML" is meant as an HTML block or if it's an option that blocks HTML in a block.

Thanks!

Attachments (1)

54110.png (3.1 KB) - added by SergeyBiryukov 6 days ago.

Download all attachments as: .zip

Change History (12)

#1 @knutsp
6 days ago

As translator, a big +1 on this. Even English has some confusing ambiguities, especially when little or no context, like block as a noun and block as a verb. And wouldn't "HTML Block" be more precise?

This ticket was mentioned in Slack in #polyglots by nekojonez. View the logs.


6 days ago

#3 @johnbillion
6 days ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 5.9
  • Version set to 5.8

@SergeyBiryukov
6 days ago

#4 in reply to: ↑ description ; follow-up: @SergeyBiryukov
6 days ago

Replying to NekoJonez:

Since it's a bit unclear if the string: "Block HTML" is meant as an HTML block or if it's an option that blocks HTML in a block.

I think it's neither of those, as this applies to any block widget and not just Custom HTML block. My understanding of this label is "HTML code of the block", see 54110.png for more context.

Introduced in [50995].

#5 @namith.jawahar
6 days ago

Wouldn't "HTML for Block" describe it better?

#6 in reply to: ↑ 4 @NekoJonez
5 days ago

Replying to SergeyBiryukov:

Replying to NekoJonez:

Since it's a bit unclear if the string: "Block HTML" is meant as an HTML block or if it's an option that blocks HTML in a block.

I think it's neither of those, as this applies to any block widget and not just Custom HTML block. My understanding of this label is "HTML code of the block", see 54110.png for more context.

Introduced in [50995].

All the more reason to add a translation note... Since now we have 3 possible options. Thanks @johnbillion for the milestone 5.9 and such. This might be a small one to fix and do but will help us translators quite a lot :D

QQ: is this from the Gutenberg plugin implemented into core...? If so, maybe we should make a github ticket so it's in the Gutenberg plugin as well.. Just thinking out loud.

This ticket was mentioned in PR #1676 on WordPress/wordpress-develop by amieiro.


45 hours ago

  • Keywords has-patch added; needs-patch removed

#9 @SergeyBiryukov
44 hours ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51814:

I18N: Add a translator comment to clarify the "Block HTML" string in the Block widget settings form.

The string refers to HTML code of the block, not an option that blocks HTML.

Follow-up to [50995].

Props Amieiro, NekoJonez, knutsp, johnbillion, namith.jawahar, SergeyBiryukov.
Fixes #54110.

This ticket was mentioned in Slack in #polyglots by evarlese. View the logs.


43 hours ago

Note: See TracTickets for help on using tickets.