#54110 closed enhancement (fixed)
Translation note requested for a block to avoid mistranslations.
Reported by: | NekoJonez | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Widgets | Keywords: | good-first-bug has-patch |
Focuses: | ui | Cc: |
Description
Could a translator note be added on this string? Since it's a bit unclear if the string: "Block HTML" is meant as an HTML block or if it's an option that blocks HTML in a block.
Thanks!
Attachments (1)
Change History (13)
This ticket was mentioned in Slack in #polyglots by nekojonez. View the logs.
3 years ago
#3
@
3 years ago
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to 5.9
- Version set to 5.8
#4
in reply to:
↑ description
;
follow-up:
↓ 6
@
3 years ago
Replying to NekoJonez:
Since it's a bit unclear if the string: "Block HTML" is meant as an HTML block or if it's an option that blocks HTML in a block.
I think it's neither of those, as this applies to any block widget and not just Custom HTML block. My understanding of this label is "HTML code of the block", see 54110.png for more context.
Introduced in [50995].
#6
in reply to:
↑ 4
@
3 years ago
Replying to SergeyBiryukov:
Replying to NekoJonez:
Since it's a bit unclear if the string: "Block HTML" is meant as an HTML block or if it's an option that blocks HTML in a block.
I think it's neither of those, as this applies to any block widget and not just Custom HTML block. My understanding of this label is "HTML code of the block", see 54110.png for more context.
Introduced in [50995].
All the more reason to add a translation note... Since now we have 3 possible options. Thanks @johnbillion for the milestone 5.9 and such. This might be a small one to fix and do but will help us translators quite a lot :D
QQ: is this from the Gutenberg plugin implemented into core...? If so, maybe we should make a github ticket so it's in the Gutenberg plugin as well.. Just thinking out loud.
This ticket was mentioned in PR #1676 on WordPress/wordpress-develop by amieiro.
3 years ago
#7
- Keywords has-patch added; needs-patch removed
See https://core.trac.wordpress.org/ticket/54110
Trac ticket:
#8
@
3 years ago
This problem comes from Gutenberg https://github.com/WordPress/gutenberg/blob/d998eb9616fdd09102a2e953964ed004aa001e99/lib/class-wp-widget-block.php#L200, so I have added this comment in this PR https://github.com/WordPress/gutenberg/pull/34840
#9
@
3 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 51814:
SergeyBiryukov commented on PR #1676:
3 years ago
#10
Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/51814.
As translator, a big +1 on this. Even English has some confusing ambiguities, especially when little or no context, like block as a noun and block as a verb. And wouldn't "HTML Block" be more precise?