#54109 closed defect (bug) (wontfix)
Classic Editor - Image edit popup toolbar no longer appears when image has link
Reported by: | ahortin | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 5.8 |
Component: | TinyMCE | Keywords: | needs-patch has-testing-info |
Focuses: | Cc: |
Description
After inserting an image into the Classic Editor, you can click on it and a small popup toolbar will appear with several alignment buttons and an Edit button.
Image without link, showing popup toolbar after being clicked:
After you add a link to the image, or if you add a link while inserting the image, this popup toolbar no longer displays when clicking on the image. The popup will flash and then disappear.
Vid: https://share.getcloudapp.com/8Lu5YGzD
macOS Big Sur 11.5.2
Firefox 92.0
WP 5.8.1
TwentyTwenty
Classic Editor (No other plugins)
Change History (6)
This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.
3 years ago
#4
@
5 weeks ago
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
It's been three years with nothing new here. Closing as wontfix. Please feel free to reopen with a patch if still interested in fixing this.
#5
follow-up:
↓ 6
@
5 weeks ago
@azaozz Have just re-tested this and the functionality appears to be working again now anyway. In most themes, you just single-click the image and the small popup appears. In Twenty Twenty, for some reason you need to double-click the image for it to appear. Either way, at least it's back working again.
#6
in reply to:
↑ 5
@
5 weeks ago
Replying to ahortin:
@azaozz Have just re-tested this and the functionality appears to be working again now anyway.
Yea, it's a bit of a hit and miss as this seems affected by styling and the old Edit Post screen has been in maintenance mode for quite some time. Thanks for re-cheking/confirming that it works now! :)
Thanks for the report!
I see the same in the Classic Editor with Twenty Twenty, but not with Twenty Seventeen, Twenty Nineteen or Twenty Twenty-One. Setting the (linked) images to
display:inline-block
seems to help in Twenty Twenty.With the block editor's Classic block, captioned images seem to have the same problem in any theme. Images without a caption seem to be fine.
block-library/editor.css:
This apparently relates to the
data-mce-selected="inline-boundary"
attribute. Removinga[href]
from that selector list makes the image toolbar display again with both the Classic blocks and Classic Editor with Twenty Twenty. However, I am not sure we should remove the MCE attribute from all links in the editor.\src\js\_enqueues\vendor\tinymce\tinymce.js: