WordPress.org

Make WordPress Core

Opened 5 weeks ago

Closed 5 weeks ago

#54163 closed defect (bug) (fixed)

The file `/wp-admin/includes/class-wp-upgrader.php` has a grammar mistake on Line 652

Reported by: zenithcity Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: minor Version:
Component: Upgrade/Install Keywords: good-first-bug has-patch
Focuses: docs Cc:

Description

A word was misused in the file /wp-admin/includes/class-wp-upgrader.php on line 652. The word 'form' was used instead of 'from' in the doc block comments.

@type bool $clear_working Whether to delete the files form the working directory after copying to the destination. Default false.

Attachments (1)

54163.patch (1.1 KB) - added by aezazshekh 5 weeks ago.
The grammar has been fixed. and the patch is attached.

Download all attachments as: .zip

Change History (6)

#1 @pbiron
5 weeks ago

@zenithcity thanx for finding that (and welcome back to Trac).

Do you feel comfortable creating a patch to correct it?

#2 @mukesh27
5 weeks ago

  • Component changed from General to Upgrade/Install
  • Keywords needs-patch good-first-bug added; typos removed
  • Version 5.8.1 deleted

Hi there!

Thanks for the ticket.

The trunk shows line 467 so please create patch according to it.

If you're doing a first-time contribution then check these links in order to create a valid patch in Trac.

https://make.wordpress.org/core/handbook/tutorials/working-with-patches/ https://make.wordpress.org/core/handbook/best-practices/writing-patches/

If you're familiar with code and git, you can use the wordpress-develop Github repository to easily contribute to WordPress: https://make.wordpress.org/core/handbook/contribute/git/

@aezazshekh
5 weeks ago

The grammar has been fixed. and the patch is attached.

#3 @aezazshekh
5 weeks ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 5.9

#5 @SergeyBiryukov
5 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51854:

Docs: Fix typo in the $clear_working parameter description in WP_Upgrader methods.

Follow-up to [30758], [51527].

Props zenithcity, aezazshekh, pbiron, mukesh27.
Fixes #54163.

Note: See TracTickets for help on using tickets.