Reset Password form: Generate Password contains aria-expanded

[alexstine]

Steps to reproduce:

1. Go to domain.com/wp-admin.
2. Select Lost your Password.
3. Enter username/email.
4. Select Get New Password.
5. Click the confirmation link in your email.
6. Notice how the Generate Password button contains

   aria-expanded="true"
   

. This button simply regenerates the password, it does not expand/collapse anything.

To fix:
Remove the aria-expanded attribute.

[alexstine]

Added a fix.

• Added a class called "skip-aria-expanded".
• Added an exclusion for the above class in jQuery.
• Removed aria-expanded from the button.

This is ready for testing.

[alexstine]

Latest patch fixes a bug on the Profile/Edit User page which causes the "Set New Password" button to keep aria-expanded even after selecting "Cancel Password Change".

[johnjamesjacoby]

Looks good to me. 👍

[alexstine]

Replying to johnjamesjacoby:

Looks good to me. 👍

@johnjamesjacoby Thanks for the quick review. :)

[sabernhardt]

introduced in r50153

[davidbaumwald]

In 52450:

Login and Registration: Remove aria-expanded from "Generate Password" button.

During password resets, the 'Generate Password" button has a aria-expanded="true" attribute, but the button itself does not expand or collapse anything. This change adds a skip-aria-expanded class to the button which is referenced in JavaScript to skip updating the aria-expanded attribute on the button itself when clicked.

This change also resets the aria-expanded attribute to false for the parent form after it's submitted.

Props alexstine, johnjamesjacoby, sabernhardt.
Fixes #54538.