Active buttons Bulk select are confusing while menu is empty

[oglekler]

Even if we are going to FSE, legacy menu will be with us a long time and this interface is very difficult to users. Active buttons which not doing anything making things less clear.

[SergeyBiryukov]

Introduced in [51006] / #21603, see also [51539] / #53654.

[krishaweb]

Here is the patch to remove the bulk action button when a menu item is empty.

[costdev]

Alternative approach that uses the existing $hide_style variable which is set when isset( $menu_items ) && 0 === count( $menu_items ).

[costdev]

Testing Info

Steps to reproduce

1. Ensure that a classic theme is active.
2. Navigate to Appearance > Menus.
3. Create a new menu, name and save it.
4. Two "Bulk Select" check buttons should appear.

Steps to test 54799.patch

1. Apply 54799.patch.
2. Refresh the menu page.
3. No "Bulk Select" check buttons should appear.
4. Add a menu item.
5. Two "Bulk Select" check buttons should appear.
6. Delete the menu item.
7. No "Bulk Select" check buttons should appear.
8. Revert the patch.

Steps to test 54799.hide_style.diff

1. Apply 54799.hide_style.diff.
2. Repeat steps 2-8 of the previous section.

Report

A test report template is available ​here (screencast optional).

Please report whether each patch is successful.

---

If both patches are successful, it is a matter of choosing which implementation to consider for commit.

[Boniu91]

@costdev It looks like the changes are applied only after saving the menu. Here are two unexpected scenarios:

1. Create a new menu
2. Add two pages to the menu (without saving it)
3. Elements are added to menu, bulk options are not there

1. Create a new menu
2. Add two pages to the menu and save it
3. Remove all pages from the menu (without saving it)
4. The menu is empty, bulk options are still present

Is it something that should be covered?

[costdev]

@Boniu91 Thanks for testing! These should be covered, and I'll try to get the patch refreshed soon.

[costdev]

Unfortunately, I didn't get time to work on updating the patch. With 6.0 RC1 tomorrow, I'm moving this to the 6.1 milestone.

[krishaweb]

Updated patch

[krishaweb]

Hey @costdev @Boniu91,
I have update the patch according to your suggestion, Please check with the latest patch.

Thanks

[hugodevos]

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: REPLACE_WITH_PATCH_URL

Environment

• OS: macOS 12.3.1
• Web Server: Nginx
• PHP: 7.4.29
• WordPress: 6.1-alpha-53344-src
• Browser: Chrome 105.0.5195.102 (Official Build) (x86_64)
• Theme: Twenty Twenty-Two (and Twenty Twenty-One)
• Active Plugins:

Actual Results

• With the patch installed it works mostly as expected.
• After installing the patch, the effect is not on reloading the page as mentioned in the Testing info in #5. It only disappears after saving the menu like mentioned in #6.
• Any newly created menu after installing the patch works as described.

[audrasjb]

Before patch

[audrasjb]

After patch: works fine with menu creation

[audrasjb]

After patch: works fine with menu items removal

[audrasjb]

I tested several use case and it looks like we're good to go.
Self assigning for commit.

[audrasjb]

In 54316:

Menus: Remove bulk action checkboxes when menu is empty.

This changeset removes the bulk action checkboxes when there is no menu item to select.

Follow-up to [51006], [51539].

Props oglekler, krishaweb, costdev, Boniu91, hugodevos, audrasjb.
Fixes #54799.
See #21603, #53654.

[milana_cap]

Might need just updating screenshots in HelpHub.