#54799 closed defect (bug) (fixed)
Active buttons Bulk select are confusing while menu is empty
Reported by: | oglekler | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Menus | Keywords: | has-patch has-testing-info commit needs-user-docs |
Focuses: | ui, administration | Cc: |
Description
Even if we are going to FSE, legacy menu will be with us a long time and this interface is very difficult to users. Active buttons which not doing anything making things less clear.
Attachments (7)
Change History (22)
@
3 years ago
Alternative approach that uses the existing $hide_style
variable which is set when isset( $menu_items ) && 0 === count( $menu_items )
.
#5
@
3 years ago
- Keywords needs-testing has-testing-info added
Testing Info
Steps to reproduce
- Ensure that a classic theme is active.
- Navigate to
Appearance > Menus
. - Create a new menu, name and save it.
- Two "Bulk Select" check buttons should appear.
Steps to test 54799.patch
- Apply 54799.patch.
- Refresh the menu page.
- No "Bulk Select" check buttons should appear.
- Add a menu item.
- Two "Bulk Select" check buttons should appear.
- Delete the menu item.
- No "Bulk Select" check buttons should appear.
- Revert the patch.
Steps to test 54799.hide_style.diff
- Apply 54799.hide_style.diff.
- Repeat steps 2-8 of the previous section.
Report
A test report template is available here (screencast optional).
Please report whether each patch is successful.
If both patches are successful, it is a matter of choosing which implementation to consider for commit
.
#6
@
2 years ago
@costdev It looks like the changes are applied only after saving the menu. Here are two unexpected scenarios:
- Create a new menu
- Add two pages to the menu (without saving it)
- Elements are added to menu, bulk options are not there
- Create a new menu
- Add two pages to the menu and save it
- Remove all pages from the menu (without saving it)
- The menu is empty, bulk options are still present
Is it something that should be covered?
This ticket was mentioned in Slack in #core-test by boniu91. View the logs.
2 years ago
#8
@
2 years ago
@Boniu91 Thanks for testing! These should be covered, and I'll try to get the patch refreshed soon.
#9
@
2 years ago
- Keywords changes-requested added
- Milestone changed from 6.0 to 6.1
Unfortunately, I didn't get time to work on updating the patch. With 6.0 RC1 tomorrow, I'm moving this to the 6.1 milestone.
#10
@
2 years ago
- Keywords changes-requested removed
Hey @costdev @Boniu91,
I have update the patch according to your suggestion, Please check with the latest patch.
Thanks
#11
@
2 years ago
Test Report
This report validates that the indicated patch addresses the issue.
Patch tested: REPLACE_WITH_PATCH_URL
Environment
- OS: macOS 12.3.1
- Web Server: Nginx
- PHP: 7.4.29
- WordPress: 6.1-alpha-53344-src
- Browser: Chrome 105.0.5195.102 (Official Build) (x86_64)
- Theme: Twenty Twenty-Two (and Twenty Twenty-One)
- Active Plugins:
Actual Results
#12
@
2 years ago
I tested several use case and it looks like we're good to go.
Self assigning for commit
.
Introduced in [51006] / #21603, see also [51539] / #53654.