PHP Warning when using 'do_parse_request' filter with '__return_false'

[dd32]

When disabling request parsing via the do_parse_request filter, if you're simply disabling the parsing entirely instead of replacing, you end up with a PHP Warning:

E_WARNING: array_keys() expects parameter 1 to be array, null given in wp-includes/class-wp.php:548

This can be reproduced by this:

add_filter( 'do_parse_request', '__return_false' );

Upon looking at the WP class, it appears that the query_vars property isn't initialised to an array() ​until after the above filter is called, but ​is then expected to be set to an array in the ​following function calls.

It seems safe to me to simply pre-set this to an empty array, and the other class properties while we're at it.

Example workaround: ​https://meta.trac.wordpress.org/changeset/11592

See PR.

Trac ticket: https://core.trac.wordpress.org/ticket/55222

Thanks for the PR! Looks like the tests did not pass previously because the isset( $this->matched_rule ) condition in WP::parse_request() needed an update to ! empty( $this->matched_rule ), since it's always set now. With this change, the tests are passing, so this seems ready for commit.

[SergeyBiryukov]

In 52804:

Query: Preinitialize the WP class properties to their default values.

This avoids an array_keys() expects parameter 1 to be array, null given PHP warning for the query_vars property in WP::build_query_string() when disabling request parsing via the do_parse_request filter.

Props dd32, SergeyBiryukov.
Fixes #55222.

Merged in https://core.trac.wordpress.org/changeset/52804.

[SergeyBiryukov]

In 52805:

Query: Correct the "matched rule" condition in WP::parse_request().

The WP::$matched_rule property is always set now, so we should check that it's not empty instead.

Follow-up to [52804].

See #55222.