Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#55555 closed enhancement (fixed)

List tables: edit Comments column header

Reported by: sabernhardt's profile sabernhardt Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: accessibility Cc:

Description (last modified by sabernhardt)

#24766 suggests removing the title attribute from this icon. And replacing the icon with the word(s) would require making the column wider and/or other changes.

Because the element already has non-visual text, I propose simply telling screen readers to ignore the icon and the title attribute. The title may not have value for people who do not use a mouse, but keeping the attribute is easier than making a fully accessible tooltip (#51006).

Attachments (2)

55555.diff (1.6 KB) - added by sabernhardt 2 years ago.
splitting span elements so the one with an icon can have aria-hidden
55555.2.diff (1.6 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (7)

2 years ago

splitting span elements so the one with an icon can have aria-hidden

#1 @sabernhardt
2 years ago

  • Description modified (diff)
  • Keywords has-patch added

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.

2 years ago

#3 @ryokuhi
2 years ago

  • Milestone changed from Awaiting Review to 6.1

We reviewed this ticket today during the Accessibility Team's weekly bug-scrub.
We support the proposal and would like it to land in 6.1, so I'm milestoning it.

#4 @SergeyBiryukov
2 years ago

Looks good to me.

55555.2.diff is a minor iteration to make the formatting of both blocks consistent.

#5 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53414:

Accessibility: List Tables: Hide the Comments column icon and title attribute from screen readers.

The element already has non-visual text, making the icon and the title attribute redundant for assistive technologies.

Follow-up to [22439], [27548], [31513], [32991], [50804].

Props sabernhardt, ryokuhi, afercia, karlgroves, SergeyBiryukov.
Fixes #55555. See #24766.

Note: See TracTickets for help on using tickets.