WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56020 closed defect (bug) (fixed)

Add prepare_links method to WP_REST_Taxonomies_Controller

Reported by: spacedmonkey's profile spacedmonkey Owned by: spacedmonkey's profile spacedmonkey
Milestone: 6.1 Priority: normal
Severity: normal Version: 4.7
Component: REST API Keywords: good-first-bug has-patch commit add-to-field-guide
Focuses: rest-api Cc:

Description

Move link logic to prepare_links method in WP_REST_Taxonomies_Controller to bring this controller inline with other controllers.

Change History (8)

#2 @spacedmonkey
2 years ago

  • Milestone changed from Awaiting Review to 6.1
  • Owner set to spacedmonkey
  • Status changed from new to assigned

#3 @spacedmonkey
2 years ago

  • Keywords commit added

#4 @spacedmonkey
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53722:

REST API: Add prepare_links method to WP_REST_Taxonomies_Controller class.

Move logic to from prepare_item_for_response to prepare_links method to bring WP_REST_Taxonomies_Controller class inline with other REST API controllers.

Props Spacedmonkey, timothyblynjacobs, dlh.
Fixes #56020.

​spacedmonkey commented on ​PR #2966:
2 years ago #5

Committed

This ticket was mentioned in ​Slack in #core-restapi by spacedmonkey. ​View the logs.
2 years ago

#7 @milana_cap
2 years ago

  • Keywords add-to-field-guide added

#8 @spacedmonkey
2 years ago

Early draft of a dev note can be found ​here.

Note: See TracTickets for help on using tickets.