Add video rotation info in wp_read_video_metadata()

[opajaap]

wp_read_video_metadata() does not include ‘rotate’ in its return array. It would be nice to add it so the server can detect that width and height should be swapped in case of a portrait oriented video from a smartphone.

Just adding:

   if ( ! empty( $data['video']['rotate'] ) ) {
		$metadata['rotate'] = $data['video']['rotate'];
   }

right after:

   if ( ! empty( $data['audio'] ) ) {
        unset( $data['audio']['streams'] );
        $metadata['audio'] = $data['audio'];
   }

will do.

[martin.krcho]

Thank you for your ticket, @opajaap.

Your suggestion sounds very reasonable. I checked the getids3 library and I can confirm that the rotate meta info is supported for the QuickTime video at the moment.
​https://github.com/JamesHeinrich/getID3/blob/master/getid3/module.audio-video.quicktime.php#L1400-L1402

Would you be able to provide a sample video and some instructions for testings this? Calling the function wp_read_video_metadata() and checking the response would obviously be the easiest check :) However, do the height and width appear swapped somewhere in the UI? Is the video displayed incorrectly after upload?

[opajaap]

I need this addition for my plugin wp-photo-album-plus

I made a copy of wp_read_video_metadata(), named it wppa_read_video_metadata() and added the proposed addition.

If you use the the current release candidate of my plugin (without the addition):
​https://downloads.wordpress.org/plugin/wp-photo-album-plus.8.2.03.006.zip

You get the wrong sizes,
when you use the dev version (with the addition):
​https://downloads.wordpress.org/plugin/wp-photo-album-plus.8.2.04.001.zip

You get the right sizes, because of this piece of code in my function wppa_fix_video_metadata():

	$mp4info = wppa_read_video_metadata( $file );

	// Make sure its a video
	if ( $mp4info['fileformat'] != 'mp4' ) {
		wppa_log( 'dbg', 'No mp4 fileformat in ' . $file . ' ' . $where );
		return false;
	}

	// Find sizes
	$videox = isset( $mp4info['width'] ) ? $mp4info['width'] : '0';
	$videoy = isset( $mp4info['height'] ) ? $mp4info['height'] : '0';
	
	// Rotated?
	if ( isset( $mp4info['rotate'] ) ) {
		$rot = $mp4info['rotate'];
		if ( $rot == 90 || $rot == 270 ) {
			$t = $videox;
			$videox = $videoy;
			$videoy = $t;
		}
	}

[opajaap]

sample portrait video

[opajaap]

Screenshot wrong sizes

[opajaap]

Right sizes

[martin.krcho]

Thank you for the sample video and also the testing scenario.

I can confirm that this ticket is valid and reproducible.

The attached patch fixes the problem. I started working on the unit tests. I am not sure we can use your video for the unit tests (for various reasons). I will try to create some sample videos for the tests that are also small in size.

[martin.krcho]

Extract_video_rotation_meta_info_if_available.patch along with unit tests.

[martin.krcho]

56217.2.patch contains the fix along with unit tests.

The attached videos rotated-video-180.mov and rotated-video-270.mov must be placed in tests/phpunit/data/uploads.

This PR improves function wp_read_video_metadata() to include video rotation in the video metadata if it's available.

Trac ticket: https://core.trac.wordpress.org/ticket/56217

[opajaap]

Still not fixed in 6.1-RC5

Does it take over three months to add this simple harmless foolproof code?:

<?php
// Rotated?
        if ( isset( $mp4info['rotate'] ) ) {
                $rot = $mp4info['rotate'];
                if ( $rot == 90 || $rot == 270 ) {
                        $t = $videox;
                        $videox = $videoy;
                        $videoy = $t;
                }
        }

[opajaap]

Correction: only rquired:

if ( ! empty( $data['video']['rotate'] ) ) {
                $metadata['rotate'] = $data['video']['rotate'];
        }