Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56225 closed defect (bug) (fixed)

`@since 6.1.0` appearing in 6.0.1

Reported by: johnbillion's profile johnbillion Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.0.2 Priority: normal
Severity: minor Version: 6.1
Component: General Keywords: needs-docs good-first-bug has-patch
Focuses: docs Cc:

Description

Two backports went into 6.0.1 but the @since tags show 6.1.0. These should be changed to 6.0.1 in trunk and backported to 6.0.2 if it happens.

  • [53661] for the block-templates feature in create_initial_theme_features() (#55681)
  • [53590] for the show_on_front, page_on_front, and page_for_posts options on the REST API settings endpoint (#56058)

Change History (9)

#1 @SergeyBiryukov
2 years ago

Thanks for catching this!

#2 @SergeyBiryukov
2 years ago

  • Keywords good-first-bug added

This ticket was mentioned in PR #2981 on WordPress/wordpress-develop by tommusrhodus.


2 years ago
#3

  • Keywords has-patch added; needs-patch removed
  • Updated @since value for register_initial_settings()
  • Updated @since value for create_initial_theme_features()

Trac ticket: https://core.trac.wordpress.org/ticket/56225

#4 follow-up: @tommusrhodus
2 years ago

Added a patch to address this, also checked for any other 6.X.X values which may be incorrect, none found.

#5 in reply to: ↑ 4 @SergeyBiryukov
2 years ago

Replying to tommusrhodus:

Added a patch to address this, also checked for any other 6.X.X values which may be incorrect, none found.

Looks great, thank you!

#6 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 53704:

Docs: Correct @since tags introduced in WordPress 6.0.1.

The associated changes were backported to the 6.0 branch, so the version should be 6.0.1 instead of 6.1.0.

This affects:

  • @since tag for the block-templates feature in create_initial_theme_features().
  • @since tag for the show_on_front, page_on_front, and page_for_posts options on the REST API settings endpoint.

Follow-up to [53590], [53661].

Props tommusrhodus, johnbillion.
Fixes #56225.

#7 @SergeyBiryukov
2 years ago

In 53705:

Docs: Correct @since tags introduced in WordPress 6.0.1.

The associated changes were backported to the 6.0 branch, so the version should be 6.0.1 instead of 6.1.0.

This affects:

  • @since tag for the block-templates feature in create_initial_theme_features().
  • @since tag for the show_on_front, page_on_front, and page_for_posts options on the REST API settings endpoint.

Follow-up to [53590], [53661].

Props tommusrhodus, johnbillion.
Merges [53704] to the 6.0 branch.
Fixes #56225.

SergeyBiryukov commented on PR #2981:


2 years ago
#8

Thanks for the PR! Merged in r53704, backported to the 6.0 branch in r53705.

This ticket was mentioned in Slack in #core by costdev. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.