Make WordPress Core

Opened 23 months ago

Closed 21 months ago

Last modified 20 months ago

#56239 closed task (blessed) (fixed)

Update jQuery UI library for 6.1

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: desrosj's profile desrosj
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: good-first-bug has-patch commit add-to-field-guide
Focuses: Cc:

Description

An update is available for the jQuery UI library. Core currently bundles 1.13.1.

If additional updates become available prior to 6.1, this ticket can be used to apply them.

Changelog: https://jqueryui.com/changelog/1.13.2/

Previously: [52648] for #54902 (5.9.1).

Change History (10)

This ticket was mentioned in PR #3081 on WordPress/wordpress-develop by seieric.


22 months ago
#1

  • Keywords has-patch added

This PR applies minor updates of jQuery UI to WordPress. They are mainly related to checkboxradio, datepicker and selectmenu.

See what is changed between 1.13.1 and 1.13.2 at https://github.com/jquery/jquery-ui/compare/1.13.1...1.13.2 or at the jQuery UI official changelog(https://jqueryui.com/changelog/1.13.2/).

Trac ticket: https://core.trac.wordpress.org/ticket/56239

This ticket was mentioned in Slack in #core by desrosj. View the logs.


21 months ago

#3 @desrosj
21 months ago

  • Owner set to desrosj
  • Status changed from new to reviewing

This ticket was mentioned in PR #3278 on WordPress/wordpress-develop by desrosj.


21 months ago
#4

Updates jQuery UI to the latest version, currently 1.13.2.

This replaces #3081.

Trac ticket: https://core.trac.wordpress.org/ticket/56239.

#5 @desrosj
21 months ago

@monolithon It looks like the "allow maintainers to update your branch" option was not checked on your PR. I noticed a few things that I've gone and corrected in a new one.

  • The anonymous modules that are registered are a bit different in Core's version of the library in an effort to maintain backwards compatibility. Many of the smaller modules are included in the core.js file instead of separate ones.
  • It looks like the PR had @VERSION tokens being used instead of 1.13.2. I think this is likely because a development copy of the library was used and not the actual 1.13.2 build distributed. I've updated the PR to correct that.
  • There were also changes to how the jQuery foundation is referred to in the file docblocks for each file. I've also included that.

#6 @Clorith
21 months ago

PR 3278 looks good!

#7 @desrosj
21 months ago

  • Keywords commit added

#8 @desrosj
21 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54209:

External Libraries: Update the jQuery UI library to version 1.13.2.

This is a bug fix release. For more information on the changes included, see https://jqueryui.com/changelog/1.13.2/.

Props Clorith, monolithon, desrosj.
Fixes #56239.

#10 @milana_cap
20 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.