Filters for Sharpening Images

[unsalkorkmaz]

Hello,

Can you add filters for these numbers;

​https://github.com/WordPress/wordpress-develop/blob/67023d0c66267420107bb565f887ae6a95b12666/src/wp-includes/class-wp-image-editor-imagick.php#L383

And GD version needs some sharpen job too, I believe.

[antpb]

Moving to 6.2. This change seems minimally impacting so it should be no problem to let those values be adjusted.

@joedolson mentioned in the recent Media meeting that we should investigate having an array of all values like compression level, filter, strategy, unsharp settings, etc. that can be filtered. If any values are missing, just use defaults.

[nosilver4u]

FYI, this was already requested in #55036
and as @galbaras mentioned, we implemented it in the EWWW Image Optimizer plugin along with the adaptiveSharpenImage() method in EWWW Image Optimizer, so feel free to yank code from there:

​https://github.com/nosilver4u/ewww-image-optimizer/blob/6ee2b5527ee537209275eafd8e7d96f5bbd041b7/classes/class-ewwwio-imagick-editor.php#L361

As far as GD, I don't know that such a thing is possible, and we always tell our users to enable Imagick if possible, which I believe aligns with the advice on the WP Site Health screen for folks using GD.

[mukesh27]

This ticket was discussed in the recent bug scrub.

@antpb, do you think this ticket is likely to move forward during this cycle?

Props to @costdev

[antpb]

thanks @mukesh27 I added a draft patch for discussion tomorrow.

[antpb]

noting, this patch is going to be refreshed with validation for the min/max that the values should be with fallbacks to the default.

+ props @joemcgill on the suggestion.

[antpb]

leaving a note also that we should make this filter name specifically mention imagick as this only impacts that configuration. + props @joedolson on the suggestion.

[costdev]

This ticket was discussed during the bug scrub. As this ticket still needs some work and 6.2 Beta 1 is being released today, I'll move this to Future Release.

The patch could also do with a couple of unit tests to verify that the filter is only called when expected, and that the returned values are validated. Adding needs-unit-tests.

Additional props: @mukesh27