Make WordPress Core

#56538 closed defect (bug) (fixed)

Twenty Thirteen: table block has an unnecessary bottom border

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.0.2
Component: Bundled Theme Keywords: has-patch has-screenshots commit
Focuses: ui, css Cc:

Description

Steps to reproduce:-

  1. Activate twenty-thirteen themes.
  2. Choose Table block.
  3. Go to the front side you can able to see after the table at the bottom there is a light border which is looking unnecessary.

Attachments (5)

CleanShot 2022-09-09 at 12.16.28@2x.png (296.3 KB) - added by nidhidhandhukiya 21 months ago.
I have attached screenshot for better understanding.
56538.patch (418 bytes) - added by nidhidhandhukiya 21 months ago.
CleanShot 2022-09-09 at 12.16.28@2x.2.png (290.0 KB) - added by maxcgparis 13 months ago.
Capture d’écran 2023-06-21 à 23.37.32.png (117.8 KB) - added by audrasjb 11 months ago.
Before patch: nasty border!
Capture d’écran 2023-06-21 à 23.38.21.png (117.7 KB) - added by audrasjb 11 months ago.
After patch: lovely table!

Download all attachments as: .zip

Change History (15)

@nidhidhandhukiya
21 months ago

I have attached screenshot for better understanding.

#1 @nidhidhandhukiya
21 months ago

  • Keywords has-patch has-screenshots added

#2 @sabernhardt
20 months ago

  • Summary changed from Twenty thirteen theme table is having unnecessary border bottom. to Twenty Thirteen: table block has an unnecessary bottom border

#3 follow-up: @sabernhardt
20 months ago

The bottom border might serve a purpose when the table has a caption, but the border was added to .wp-block-table before captions were available in the table block (changeset 43796).

#4 @sabernhardt
14 months ago

  • Milestone changed from Awaiting Review to 6.3

#5 @maxcgparis
13 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/ticket/56538

Environment

  • OS: Windows 10
  • Web Server: Apache
  • PHP: 8.0.0
  • WordPress: 6.3-alpha-55661
  • Browser: Chrome 112.0.5615.138
  • Theme: Twenty Thirteen
  • Active Plugins:
    • WordPress Beta Tester 3.3.7

Actual Results

  • ✅ Issue resolved with patch.

Additional Notes

  • Any additional details worth mention.

props @pouicpouic

#6 @pooja1210
12 months ago

Hi,

Test report for patch - https://core.trac.wordpress.org/attachment/ticket/56538/56538.patch

Environment:
WordPress: v6.2.2
Theme: Twenty Thirteen
OS: Mac
Browser: Chrome

Steps to reproduce:

  1. Activate the Twenty Thirteen theme.
  2. Create or edit a Page/Post.
  3. Add a table block.
  4. Preview the changes.
  5. Observe the border line present below the table.

Expected Result:
Unnecessary bottom border should not be visible for table block.

Screenshot:
Before: https://prnt.sc/b7SiCnvroUfW
After: https://prnt.sc/Yb0sqLzB3Col

Patch is working as expected.

Thanks!

#7 in reply to: ↑ 3 @audrasjb
11 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Replying to sabernhardt:

The bottom border might serve a purpose when the table has a caption, but the border was added to .wp-block-table before captions were available in the table block (changeset 43796).

+1. By the way, the border should only be displayed when a caption is used :P

Let's remove this.
I'll give it a quick test, then hopefully, commit.

@audrasjb
11 months ago

Before patch: nasty border!

@audrasjb
11 months ago

After patch: lovely table!

#8 @audrasjb
11 months ago

  • Keywords commit added
  • Status changed from reviewing to accepted

Looks perfect to me, let's ship this in 6.3!

#9 @sabernhardt
11 months ago

The border probably should be removed from editor-blocks, too.

#10 @audrasjb
11 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55973:

Twenty Thirteen: Remove an unnecessary border from Table block.

This changeset removes an unwanted border showing up at the bottom of the Table block.

Props nidhidhandhukiya, sabernhardt, maxcgparis, pooja1210, audrasjb.
Fixes #56538.

Note: See TracTickets for help on using tickets.