Opened 4 years ago
Closed 4 years ago
#57199 closed defect (bug) (fixed)
Bundled themes: Remove title attributes
| Reported by: | sabernhardt | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.2 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | accessibility |
Description
Searching bundled themes for title= returned 59 results.
Redundant (13):
- "Skip to content" in Twenty Ten, Twenty Twelve and Twenty Thirteen (not Twenty Eleven since r27569)
- Site name in Twenty Ten (header and footer), Twenty Twelve and Twenty Thirteen
- Author name in the H1 heading of the author.php template in the four themes from Twenty Ten to Twenty Thirteen
- Date and time in the comment timestamp links of Twenty Nineteen and Twenty Twenty
Empty link with title attribute:
- Twenty Eleven's Showcase template has empty links to each featured post slide with "Featuring: [post title]" as a title attribute. The attribute can stay if it's silenced, but the links need accessible text.
Other title attributes to consider removing:
Change History (15)
This ticket was mentioned in PR #3681 on WordPress/wordpress-develop by @sabernhardt.
4 years ago
#2
- Keywords has-patch added
This starts with the obvious problems:
- Removes 13 redundant
titleattributes. - Adds accessible text to the Showcase template links. The
titleattribute remains, silenced witharia-hidden, with a style change so it still covers the full link area.
Trac ticket: https://core.trac.wordpress.org/ticket/57199
#3
in reply to: ↑ 1
@
4 years ago
Replying to audrasjb:
Concerning empty links with title attribute, shouldn't we replace the
titleattribute with a screen reader text (visually hidden text) instead?
Ok I just saw the implementation proposed for twentyeleven/showcase.php. It looks good to me.
#7
@
4 years ago
This changeset looks good to me and doesn't break anything in the related themes.
I'm going to commit it theme by theme, just in case.
@audrasjb commented on PR #3681:
4 years ago
#14
PR fully committed, see the related ticket.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Great initiative!
Concerning empty links with title attribute, shouldn't we replace the
titleattribute with a screen reader text (visually hidden text) instead?