Make WordPress Core

Opened 16 months ago

Closed 15 months ago

Last modified 15 months ago

#57429 closed defect (bug) (fixed)

Clarify "Allow trackbacks or pingbacks on this page" text

Reported by: jeremyfelt's profile jeremyfelt Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Pings/Trackbacks Keywords: good-first-bug has-patch commit
Focuses: administration, ui-copy Cc:

Description

In the discussion meta box on a post type, the following is displayed:

  • Allow comments
  • Allow trackbacks and pingbacks on this page

I would expect both lines to follow a similar pattern, in which case "on this page" can be removed.

If this information is useful—in context, I'm not sure how, then "page" should be populated by the post type's singular (lowercase?) label.

Prior to [12228], only "Allow trackbacks and pingbacks" was used. This was partially reverted in [12323] via #11346 to fix the "Allow comments" text, but trackbacks and pingbacks was left as is.

Attachments (3)

discussion-meta-box-classic-editor.2.png (4.6 KB) - added by sabernhardt 16 months ago.
Discussion meta box in Classic Editor, under post content
discussion-meta-box-side.png (4.0 KB) - added by sabernhardt 16 months ago.
Discussion meta box in Classic Editor, in side area
discussion-panel-block-editor.png (4.1 KB) - added by sabernhardt 16 months ago.
Discussion panel in block editor's sidebar

Download all attachments as: .zip

Change History (13)

@sabernhardt
16 months ago

Discussion meta box in Classic Editor, under post content

@sabernhardt
16 months ago

Discussion meta box in Classic Editor, in side area

@sabernhardt
16 months ago

Discussion panel in block editor's sidebar

#1 @sabernhardt
16 months ago

  • Component changed from Text Changes to Pings/Trackbacks
  • Focuses administration ui-copy added

The post type label was mentioned in ticket:13539#comment:6.

However, the wording probably should be simplified instead. The block editor already shortened the text to "Allow pingbacks & trackbacks" without the link (GB3312). That change may have helped it fit in the sidebar panel, though the meta box could go in the narrow side area of the Classic Editor, too.

#2 @audrasjb
16 months ago

Good point, but to avoid translation difficulties with the gender of "this" (regarding the post type), I'd completely remove "on this page".

It would also make it more consistent with the block editor :)

#3 @audrasjb
16 months ago

If someone is interested to put together a patch, here is the string to edit: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/meta-boxes.php#L807

This ticket was mentioned in PR #3831 on WordPress/wordpress-develop by virgar38.


15 months ago
#4

  • Keywords has-patch added; needs-patch removed

#5 @virgar
15 months ago

Hello everyone,

I tried to make a pull request, this is my first contribution 😀 !

Virginie

Last edited 15 months ago by virgar (previous) (diff)

#6 @audrasjb
15 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.2

Thanks @virgar for this contribution!

Self-assigning for commit consideration.

#7 @audrasjb
15 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#8 @sabernhardt
15 months ago

I had considered the possibility of using the same text for both editors, but that could involve either removing the link or forcing it to open in a new tab. I don't like either of those options.

I agree with committing the patch (PR) as it is.

#9 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55040:

Pings/Trackbacks: Remove a mention of the "Page" post type from the Discussion meta box.

This changeset removes a mention of the "Page" post type from the Discussion meta box as this is a generic meta box, used for multiple post types. It makes it more consistent with the other option available in the meta box ("Allow comments") and also with the corresponding option in the block editor.

Follow-up to [12323].

Props jeremyfelt, sabernhardt, audrasjb, virgar.
Fixes #57429.
See #11346.

Note: See TracTickets for help on using tickets.