WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57550 closed defect (bug) (fixed)

Block editor: separate content styles for the iframe

Reported by: ellatrix Owned by: hellofromTonya
Priority: normal Milestone: 6.2
Component: Editor Version:
Severity: normal Keywords: has-patch gutenberg-merge commit
Cc: Focuses:

Description (last modified by hellofromTonya)

This ticket is the PHP changes for the initiative to:

  • Separate the content styles contained in the block editor package into a separate stylesheet.
  • Avoid loading all block editor styles into the iframe.

Changes:

  • Remove the 'wp-block-editor' and 'wp-block-library' from the iframe's stylesheet collection (i.e. _wp_get_iframed_editor_assets()).
  • Add the new 'wp-block-editor-content' for the separate stylesheet to the list of editor ('wp-edit-blocks') dependencies.

This ticket is for the PHP changes in ​https://github.com/WordPress/gutenberg/pull/44298. The changes within the editor and block library will be included in a @wordpress packages update (see #57471).

Change History (7)

This ticket was mentioned in ​PR #3903 on ​WordPress/wordpress-develop by ​@ellatrix.
4 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/57550

#2 @hellofromTonya
4 years ago

  • Description modified (diff)
  • Keywords gutenberg-merge added
  • Milestone Awaiting Review → 6.2
  • Owner set to hellofromTonya
  • Status new → reviewing
  • Summary Block editor: separate content styles for the iframe (PHP backport) → Block editor: separate content styles for the iframe
  • Version trunk

​@hellofromTonya commented on ​PR #3903:
4 years ago #3

Currently reviewing for commit.

#4 @hellofromTonya
4 years ago

  • Keywords commit added

​PR 3903 is ready for commit.

​@hellofromTonya commented on ​PR #3903:
4 years ago #5

Good. The CI jobs are all green. The failures were unrelated to this PR.

#6 @hellofromTonya
4 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 55179:

Editor: Separate content styles for iframe in wp_get_iframed_editor_assets() and wp_default_styles().

This changeset:

  • Removes the 'wp-block-editor' and 'wp-block-library' from the iframe's stylesheet collection (i.e. _wp_get_iframed_editor_assets()).
  • Adds the new 'wp-block-editor-content' for the separate stylesheet to the list of editor ('wp-edit-blocks') dependencies.

Why?

These PHP changes are part of the initiative to:

  • Separate the content styles contained in the block editor package into a separate stylesheet.
  • Avoid loading all block editor styles into the iframe.

References:

Follow-up to [53160], [50761].

Props ellatrix, youknowriad.
Fixes #57550.

Note: See TracTickets for help on using tickets.