Editor: Update @wordpress packages for WordPress 6.2

[Mamaduka]

Update @wordpress packages with packages published from Gutenberg.

[azaozz]

Think this ticket should be repurposed a little. The "Backport PHP changes from Gutenberg's lib/compat/wordpress-6.2/ files." should not be in one ticket, instead each Gutenberg PR that was merged/closed and contains PHP changes should get a separate Trac ticket (and a patch/PR) for syncing these PHP changes to core.

See ​https://github.com/WordPress/gutenberg/issues/47187#issuecomment-1384107056 and the following comment.

[peterwilsoncc]

As noted in the original PR for removing wp-nux, I think it needs to be retained in core.

The performance gain removing the plugin can be gained by updating the style dependencies (which are unused where currently listed) but retaining nux will avoid breaking backward compatibility.

See my ​comment on the original PR.

[hellofromTonya]

As discussed, PHP backports in lib/ will have separate Trac tickets for better tracking and commit history. This Trac ticket will be for @wordpress package updates.

[hellofromTonya]

Adding the experimental keyword for the backport/sync of Gutenberg into Core tracking.

Alternative approach to PR ​https://github.com/WordPress/wordpress-develop/pull/3775 for deprecating nux ​https://github.com/WordPress/gutenberg/pull/46110

In the discussion for the original pull request, it seems the wp-edit-post and wp-editor styles no longer require the wp-nux css file as a dependency.

This removes the CSS dependencies while retaining the JavaScript to ensure JavaScript continues to function for extenders still using the nux package. As the styles are not needed, this will see a small performance gain for most WordPress installs.

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This PR updates the WordPress packages with the latest released ones from Gutenberg 15.0.1.

While updating the packages, it was necessary to bring the following changes as well:

• React upgrade to 18.2.0
• iframe the block theme editor. (Related PRs ​https://github.com/WordPress/wordpress-develop/pull/3904, ​https://github.com/WordPress/wordpress-develop/pull/3903 )

Trac ticket: https://core.trac.wordpress.org/ticket/57471

[azaozz]

This PR: ​https://github.com/WordPress/wordpress-develop/pull/3775 doesn't seem linked to a trac ticket. Adding it here for visibility.

This is the PR backporting the ​https://github.com/WordPress/gutenberg/pull/46110 Gutenberg PR.

The nux package has been deprecated 26 months ago and after checking that removing the remaining code in this package is very low impact, we decide to remove the package and replace it with empty script and style to avoid breaking third-party scripts and styles adding these as dependencies.

Trac ticket https://core.trac.wordpress.org/ticket/57471

I noticed that we have a few methods with the gutenberg_ prefix in the block-library packages. I'm looking into this.

@felixarntz, I already fixed gutenberg_ prefix issue in Gutenberg repo. See ​https://github.com/WordPress/gutenberg/pull/47649.

@ntsekouras and I will start working on package updates that include recent fixes.

Mostly looks good, just one nit-pick and the remaining gutenberg_ prefixes that need to be replaced. Is that something you can just update in this PR or does it require a fix on the Gutenberg side?

Actually, I can't touch these files here, even the nitpicks suggested here because every time someone will do npm install it will revert these changes locally causing confusion. So I think we should instead make a PR to Gutenberg and wait for the next round of package release.

I've just noticed that there's a blocks fixtures tests in Core right now. Anyone know why this test has been moved from Gutenberg to here? It's just going to add maintenance burden for us for a small value since all the code for blocks is coming through package. In other words, these tests are better by their code (in the Gutenberg repo).

Ok I've managed to fix all the failing tests here. It's not perfect but It should be good to land to unblock the PRs that depend on it.

I've noticed a small style glitch on the empty post placeholder. Something to keep an eye on after all the backports.

@felixarntz It needs to be addressed on Gutenberg, that way it comes in the next package update. You can't make changes to these files in Core.

@youknowriad Ah right, forgot about that, thanks!

[flixos90]

@youknowriad @Mamaduka Are the changes in ​https://github.com/WordPress/wordpress-develop/pull/3914 still waiting for another commit to land, or are we good to commit them?

[youknowriad]

I've got the following error while committing.

*
PHP error in: trunk/src/wp-includes/blocks/blocks-json.php:

Parse error: syntax error, unexpected string content "_", expecting ")" in Standard input code on line 1
Errors parsing Standard input code
*

Since this file is an auto-generated one, I'm not really sure how to deal with this? Any precedent here?

[hellofromTonya]

Converting into a "blessed" ticket.

Why? The @wordpress packages are resynchronized / updated from Gutenberg into Core throughout the major release cycle, i.e. into beta. These packages include enhancements, features, and bug fixes.

Please note:
The PHP code being copied from Gutenberg into Core (sometimes called a "backport") should separate Trac ticket(s).

[hellofromTonya]

Created #57643 for tracking and scope of removing the @wordpress/nux package, ie ​PR 3775.

Why? It's more involved than a package updates from Gutenberg into Core. Having its own ticket will help to ensure it doesn't get lost in this ticket while encapsulating the discussion and context (for the future).

Created a Trac ticket https://core.trac.wordpress.org/ticket/57643 to capture this scope of work, ie for (a) future context/history and (b) ensure it's not lost in the package updates ticket.

[desrosj]

@youknowriad I was able to reproduce the issue you described, though very inconsistently. If you look at the generated blocks-json.php file, it seems that the Grunt task stopped somewhere within the list-item block and the file just ends with '_ causing the fatal error.

I have two checkouts of wordpress-develop locally (one using the Git mirror, one using SVN), and I could only get it to happen in the one from SVN for whatever reason. I'm not sure what the reason is, though. This could be some type of time or memory limit at some point of the build process.

Since the Grunt task that creates this file uses the json2php npm package, I looked to see if the version of that dependency had changed recently. I was looking to update it recently but hadn't yet, and there are only minor changes in the two point releases since it was last updated in [54276].

For whatever reason, I am unable to reproduce the problem after updating that dependency. To rule this out, I've gone and committed this update in [55232] and updated the attached PR by merging in trunk after this change.

Could a few others run some testing locally to confirm they no longer see this problem?

[peterwilsoncc]

I'm not seeing this issue in my svn trunk checkout but wasn't able to reproduce it with r55231 checked out, svn up -r55231.

In the past I have seen the build script get confused if the package hash file is changed during the build, so I tend to update packages by running npm run grunt clean:qunit; npm run build:dev; instead of an install.

$ php -v
PHP 7.4.33 (cli) (built: Jan 21 2023 07:11:51) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.33, Copyright (c), by Zend Technologies

$ php --syntax-check src/wp-includes/blocks/blocks-json.php
No syntax errors detected in src/wp-includes/blocks/blocks-json.php

Opening the file and it looks good too.

---

I'm not going to commit because I am unsure if the svn:ignore prop needs any changes in the blocks directory.

[youknowriad]

In 55246:

Block Editor: Updated the WordPress packages to include Gutenberg 15.1.0 changes.

In addition to all the packages being updated to the latest versions,
this commit also includes some mandatory changes to avoid editor breakage:

• Update React to to 18.2.0.
• Add the right stylesheets to support iframed block editors.

Props ntsekouras, mamaduka, flixos90, desrosj, peterwilsoncc.
See #57471.

[youknowriad]

Thanks for your help everyone, I was able to generate the right block-json file by running that command manually.

This has been committed

Thank you, Riad!

The changeset - https://core.trac.wordpress.org/changeset/55246.

[kebbet]

This changeset introduced an incorrect way to contacternate a string, in the function render_block_core_read_more this code is found:
'' !== $post_title ? $post_title : __( 'untitled post ' ) . $post_ID

The translateable string should include a placeholder for the $post_ID variable. Something like __( 'untitled post %s' );

The docblock for the function is also missing a @since tag.

[youknowriad]

Indeed that doesn't sound right @kebbet I'll try to ping the right folks on Gutenberg to prepare a PR for the next package update batch. These files are not files we can edit directly on Core.

[youknowriad]

I created the following issue to track that feedback ​https://github.com/WordPress/gutenberg/issues/47812

[kebbet]

I get a fatal error with Twenty Twenty-Three since [55246].

See: ​https://github.com/WordPress/gutenberg/issues/47822

[gziolo]

Opened ​https://github.com/WordPress/gutenberg/pull/47831 in Gutenberg to mirror the fix applied by @desrosj with [55232] for the json2php package to stay on the safe side.

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/3eb2c536278d5a17f698b9c378fe3db746a89622

Trac ticket: https://core.trac.wordpress.org/ticket/57471

[youknowriad]

In 55257:

Block Editor: Updates the WordPress packages with all the fixes targetted for WP 6.2 beta1.

Includes the following changes

• Fix multi entities saved state in the post editor
• Adds a global save button to the site editor
• Shadow: move shadow to own panel
• [Block Editor]: Lock experimentalBlockInspectorAnimation setting
• useBlockSync: change subscribed.current on unsubscribe
• [Block Library - Gallery]: Minor code quality update
• [Patterns]: Reorder pattern categories
• Fix inline preview infinite render
• Show a pointer/hint in the settings tab informing the user about the styles tab
• I18N: update string concatenation method in read more block
• LocalAutosaveNotice: use stable notice id to prevent double notices
• Navigation: Remove the IS_GUTENBERG_PLUGIN check around block_core_navigation_parse_blocks_from_menu_items

Props mamaduka, ntsekouras, kebbet.
See #57471.

Committed in https://core.trac.wordpress.org/changeset/55257

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/1bf01c01a8238ce3a681ad1e517f86033818b78d

Includes the following changes:

• Add missing period in keyboard shortcut descriptions
• Site Editor: Append template type and name to the site editor page title
• Specify active color state for template navigation button
• Global Styles: Move more link about custom CSS to part of description
• ToolsPanel: Display optional items when values are updated externally
• File block: Re-add editor styles for classic themes
• Enable undo after creating a new menu
• Style Book: Exclude blocks that are not allowed to insert
• Add basic tsconfig.json validation
• Fix Experiments native variant breakage
• Update moment and moment-timezone packages to fix timezone issues
• NavigatorButton: Reuse Button types
• ToolsPanel: Ensure display of optional items when panel id is null
• ColorPalette: Ensure text label contrast checking works with CSS variables
• Components: Add support for named arguments in the navigator components
• Rename experiments package to private-apis
• Cherry-pick CLI: Fix the default label to match the documentation
• Handle block metadata attribute and related experimental APIs
• Fix: Remove browser default border for iframe in the editor
• [Layout]: Fix align controls for hybrid themes
• Visual Regression tests: use default playwright utils
• SelectControl: Fix multiple prop styling
• Fix clicking on the toggle button not closing the block inserter
• Update deps for the useEffect that creates navigation menus
• Minor updates in Private APIs docs
• Site Editor: Fix custom Template Parts rename action
• [Block Library - Cover]: Ensure url is not malformed due to sanitization through wp_kses
• Revert "Prevent the image from being resized larger than its container"
• Lodash: Remove from @wordpress/keycodes package
• Distraction free mode: Fix keyboard shortcut not working
• Popover: lock the experimentalPopoverPositionToPlacement function
• Rename the "experiments" export to "privateApis"
• Add an aria label to the site save dialog
• Navigator: add more pattern matching tests, refine existing tests
• Add parent navigation support for the navigator component
• Add back link to Design heading in site editor navigation to return to Dashboard
• Add a nested level when selecting templates or template parts
• Move site editor 6.2 specific code to the right file
• Fix site editor navigation

Currently reviewing.

[hellofromTonya]

Currently reviewing ​PR 4070 for commit.

[hellofromTonya]

​PR 4070 is ready for commit:

• Package version numbers match ​https://github.com/WordPress/gutenberg/commit/1bf01c01a8238ce3a681ad1e517f86033818b78d ✅
• CI is passing ✅
• Local testing - no errors ✅

Prepping commit now in time for 6.2 Beta 2.

[hellofromTonya]

In 55333:

Editor: Update @wordpress packages for 6.2 Beta 2.

Updates the @wordpress packages to include the following changes:

• Add missing period in keyboard shortcut descriptions
• Site Editor: Append template type and name to the site editor page title
• Specify active color state for template navigation button
• Global Styles: Move more link about custom CSS to part of description
• ToolsPanel: Display optional items when values are updated externally
• File block: Re-add editor styles for classic themes
• Enable undo after creating a new menu
• Style Book: Exclude blocks that are not allowed to insert
• Add basic tsconfig.json validation
• Fix Experiments native variant breakage
• Update moment and moment-timezone packages to fix timezone issues
• NavigatorButton: Reuse Button types
• ToolsPanel: Ensure display of optional items when panel id is null
• ColorPalette: Ensure text label contrast checking works with CSS variables
• Components: Add support for named arguments in the navigator components
• Rename experiments package to private-apis
• Cherry-pick CLI: Fix the default label to match the documentation
• Handle block metadata attribute and related experimental APIs
• Fix: Remove browser default border for iframe in the editor
• [Layout]: Fix align controls for hybrid themes
• Visual Regression tests: use default playwright utils
• SelectControl: Fix multiple prop styling
• Fix clicking on the toggle button not closing the block inserter
• Update deps for the useEffect that creates navigation menus
• Minor updates in Private APIs docs
• Site Editor: Fix custom Template Parts rename action
• [Block Library - Cover]: Ensure url is not malformed due to sanitization through wp_kses
• Revert "Prevent the image from being resized larger than its container"
• Lodash: Remove from @wordpress/keycodes package
• Distraction free mode: Fix keyboard shortcut not working
• Popover: lock the experimentalPopoverPositionToPlacement function
• Rename the "experiments" export to "privateApis"
• Add an aria label to the site save dialog
• Navigator: add more pattern matching tests, refine existing tests
• Add parent navigation support for the navigator component
• Add back link to Design heading in site editor navigation to return to Dashboard
• Add a nested level when selecting templates or template parts
• Move site editor 6.2 specific code to the right file
• Fix site editor navigation

References:

• ​Gutenberg's commit for publishing the packages

Follow-up to [55257].

Props ntsekouras.
See #57471.

Committed via https://core.trac.wordpress.org/changeset/55333.

[hellofromTonya]

Resetting commit keyword and unassigning as all work has been committed.

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/ccabeeffe1fe117c3934ec7705c15d52857d9a87

This includes just the following change: ​https://github.com/WordPress/gutenberg/pull/48237 to see if it resolves a ​bad Popover issue for 6.2 beta, which in my testing it does.

There will be another packages release for beta 3 tomorrow with the rest fixes.

[gziolo]

In 55366:

Backport editor changes from Gutenberg for WordPress 6.2 Beta 3

Updates the @wordpress packages to include the following change:

• Pin valtio version

References: ​Gutenberg's commit for publishing the packages

Props ntsekouras.
See #57471.

Committed with https://core.trac.wordpress.org/changeset/55366.

[hellofromTonya]

Renamed the title to focus this ticket on what is being introduced into Core. The word "backport" has a different meaning in Core, i.e. it means to backport changes to previous WordPress version branches.

This ticket is meant for updating the @wordpress packages that are consumed in Core.

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/1e2b2f680c6378f789d6660bc04b30e35e3a33a3

Includes the following changes:

• Upgrade Playwright to 1.30.0
• [Block Editor - Inserter]: preload media categories empty check - client side
• Navigation: Fixes undo and redo for nesting operations in the navigation block's inspector
• Fix: OffCanvasEditor does not inserts submenu on collapsed items.
• OffCanvasEditor: Only allow some blocks to be converted to submenus
• Navigation: Updates "Add Submenu item" text to "Add Submenu link"
• Update: Make OffCanvasEditor use LeafMoreMenu by default.
• Template Part: Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet()
• Widget Editor: Fix a problem with 'Move to Widget Area' button not working
• Reusable Blocks: Use React 18 rendering for import dropdown
• useAsyncList: flush state updates when processing queue
• Refactor the site editor URLs for better backward compatibility
• Template editor: only disable the save button if no changes rather than hiding it
• [Quote]: Fix deprectated large style specificity rule
• Style Book: Allow button text labels for style book icon
• List View: Scroll selected block into view when single block selection changes
• Post editor: revert iframed editor for WP core only
• Fix the Publish region position and focus style.
• Remove "& Shadow" from the Border ScreenHeader title
• Site editor: specify focus state color for template navigation button

Do e2e tests require some changes after including "Post editor: revert iframed editor for WP core only"?

What e2e tests are run here?

Do e2e tests require some changes after including "Post editor: revert iframed editor for WP core only"?

Probably yes. I'm looking at it right now.

This bit needs to be reverted:

​https://github.com/WordPress/wordpress-develop/commit/07fc9b2d7449314ee658d764ce162e99cef6783b#diff-54454877010d42c1ee0c0c0126c2cb81fc5b7c723197ab2888feea8fd3a49bac

[gziolo]

In 55392:

Update the WP packages with fixes prior to WP 6.2 beta 3

Includes the following changes:

• Upgrade Playwright to 1.30.0
• [Block Editor - Inserter]: preload media categories empty check - client side
• Navigation: Fixes undo and redo for nesting operations in the navigation block's inspector
• Fix: OffCanvasEditor does not inserts submenu on collapsed items.
• OffCanvasEditor: Only allow some blocks to be converted to submenus
• Navigation: Updates "Add Submenu item" text to "Add Submenu link"
• Update: Make OffCanvasEditor use LeafMoreMenu by default.
• Template Part: Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet()
• Widget Editor: Fix a problem with 'Move to Widget Area' button not working
• Reusable Blocks: Use React 18 rendering for import dropdown
• useAsyncList: flush state updates when processing queue
• Refactor the site editor URLs for better backward compatibility
• Template editor: only disable the save button if no changes rather than hiding it
• [Quote]: Fix deprectated large style specificity rule
• Style Book: Allow button text labels for style book icon
• List View: Scroll selected block into view when single block selection changes
• Post editor: revert iframed editor for WP core only
• Fix the Publish region position and focus style.
• Remove "& Shadow" from the Border ScreenHeader title
• Site editor: specify focus state color for template navigation button

References: ​Gutenberg's commit for publishing the packages

Props ntsekouras, ellatrix.
See #57471.

Committed with https://core.trac.wordpress.org/changeset/55392.

Well obviously, that's the minimum we should be doing. I think it's not enough and we discussed this over and over again. There's no point in repeating the same arguments over and over. We can hear if we don't want to.

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/35f10c183655e9196d4ea12b8fa499a8ecbb7b6a

Includes the following changes:

• Only add layout classes to inner wrapper if block is a container.
• Revert dynamic block anchor support
• [Inserter - Media tab]: Upload Openverse images when inserted
• SpacingSizesControl: Fix white dot on thumb
• Site Editor: update the edit button
• Change "Browse all templates" to "Manage all templates" in template details popover
• Remove TemplateAreas from template details
• Add support for orientation-based block movers to core/social-links
• Site Editor: polish add template modal style
• Match color of the focus template view with site dark material
• Site Editor: Fix routing for Classic themes using block-based template parts
• Remove broken site editor redirect
• Make the template customized info accessible
• Sort templates and template parts by slug
• Prevent distracting focused back button on site editor load
• Fix: Content only CPT template locking.
• Pin floating-ui/react-dom version
• Widget Importer: Don't render controls when there's nothing to import
• Post Editor: Update postContentBlock check to see if the block is valid
• Site Tagline: Add example so that it will display in style book
• Remove copy for managing a block's style variations
• Fix the site editor home page loading when installed in a subdirectory
• Global Styles: Display preset names via the tooltip
• [Query Loop] Fix top border in pattern selection modal
• Site Editor: Fix the 'Browse all' link in the template details modal
• Site Editor: Fix the tooltip and shortcut for the global save button
• Make the Site Logo block placeholder state smaller
• Site Editor Sidebar: Add line-height for template/parts name and update width for edit button
• Style Book: Focus the Style Book when opened, and enable ESCAPE key to close
• [Site Editor]: Set html block as freeform fallback block
• Make the performance tests more stable
• Adds all allowed innerblocks to the inspector animation experiment
• Revert Link control UX changes for WP 6.2
• Fix Site Editor perf tests
• Playwright: fix request utils for non Docker envs

[gziolo]

In 55440:

Update the WP packages with fixes prior to WP 6.2 beta 4

This updated the packages to the latest versions with the latest fixes.

Gutenberg changes: ​https://github.com/WordPress/gutenberg/commit/35f10c183655e9196d4ea12b8fa499a8ecbb7b6a

Includes the following bug fixes:

• Only add layout classes to inner wrapper if block is a container.
• Revert dynamic block anchor support
• [Inserter - Media tab]: Upload Openverse images when inserted
• SpacingSizesControl: Fix white dot on thumb
• Site Editor: update the edit button
• Change "Browse all templates" to "Manage all templates" in template details popover
• Remove TemplateAreas from template details
• Add support for orientation-based block movers to core/social-links
• Site Editor: polish add template modal style
• Match color of the focus template view with site dark material
• Site Editor: Fix routing for Classic themes using block-based template parts
• Remove broken site editor redirect
• Make the template customized info accessible
• Sort templates and template parts by slug
• Prevent distracting focused back button on site editor load
• Fix: Content only CPT template locking.
• Pin floating-ui/react-dom version
• Widget Importer: Don't render controls when there's nothing to import
• Post Editor: Update postContentBlock check to see if the block is valid
• Site Tagline: Add example so that it will display in style book
• Remove copy for managing a block's style variations
• Fix the site editor home page loading when installed in a subdirectory
• Global Styles: Display preset names via the tooltip
• [Query Loop] Fix top border in pattern selection modal
• Site Editor: Fix the 'Browse all' link in the template details modal
• Site Editor: Fix the tooltip and shortcut for the global save button
• Make the Site Logo block placeholder state smaller
• Site Editor Sidebar: Add line-height for template/parts name and update width for edit button
• Style Book: Focus the Style Book when opened, and enable ESCAPE key to close
• [Site Editor]: Set html block as freeform fallback block
• Make the performance tests more stable
• Adds all allowed innerblocks to the inspector animation experiment
• Revert Link control UX changes for WP 6.2
• Fix Site Editor perf tests
• Playwright: fix request utils for non Docker envs

See #57471.
Props Mamaduka, ntsekouras.

Committed with https://core.trac.wordpress.org/changeset/55440.

[gziolo]

In 55441:

Build: Regenerate correctly the block-json.php file

See #57471.
Follow-up [55440].

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/d14fea64bd9ad9d2d86047936974dbed39a5b5b3

Includes the following changes:

• Add border radius to off canvas navigation menu items
• Remove border from quick inserter child elements
• Show variant patterns even if there are no patterns for the Query Loop block
• Order initial block items in Navigation with PrivateInserter
• Update: Add descriptions to all panels in the Site Editor's dark side
• Fix typo in template parts description
• Fix: Browse mode descriptions margin
• Fix: Show creation popover on empty page links in the navigation sidebar
• Make sure the directly inserted block in the Nav block is a Page link
• Fix browser history when synchronising state with urls
• Navigation Sidebar: Change the logic about which navigation gets selected for the sidebar
• Fixes extra UI in navigation block inspector
• Renames parent selection boolean param and improves docs
• Widget Importer: Fix Widget Group block imports
• Don't add Post Content layout styles to title in the post editor
• Site editor: Add hover animation to site editor canvas
• Prevent the saving button from showing when renaming templates
• Navigation Block: Fix big spinner
• Navigation: Don't save the level of the link in an attribute
• Focus 1st parent block on block remove, if no previous block is available
• Migrate block deletion E2E tests to Playwright
• Navigation: Performance: improve params in block_core_navigation_get_most_recently_published_navigation
• Navigation Block inspector: fix link UI popover opening on links that have a url
• Fix for WP_Theme_JSON_Resolver_Gutenberg::get_merged_data
• Site Editor: Add page details when viewing a specific page.
• Fix site editor sidebar scrollbars
• Fix: Custom link UI does appears outside canvas on the sidebar navigation
• Fix: Make navigation page list load its items on navigation sidebar

# Test Report

Issue: [Site Editor] White screen when using browser back button ​https://github.com/WordPress/gutenberg/issues/48726

## Steps to Reproduce

1. Navigate to the Site Editor 🐞
2. Click on the navigation sidebar.
3. Click the browser's back button 🐞
4. Click the browser's back button again 🐞

## Expected Results

When testing a patch to validate it works as expected:

• ✅ The Site Editor's URL should be http://localhost:8889/wp-admin/site-editor.php
• ✅ Clicking on the browser's back button should return to the Dashboard http://localhost:8889/wp-admin/

When reproducing a bug:

• ❌ When entering the Site Editor, the path query arg is wrong /site-editor.php?canvas=init&path=%2F
• ❌ First click > nothing happens
• ❌ Second click > Get a white screen

Environment

• OS: macOS
• Browser: Chrome, Firefox, and Edge
• Plugins: none
• Theme: TT3
• WordPress: trunk and with this PR

Actual Results

When reproducing a bug/defect:

• ❌ Confirmed: the Site Editor URL path query arg is wrong /site-editor.php?canvas=init&path=%2F.
• ❌ Confirmed: clicking on the browser's back button does nothing.
• ❌ Confirmed: again clicking on the browser's back button shows a white screen.

When testing the bugfix patch:

• ✅ Confirmed: Site Editor's URL is correct.
• ✅ Confirmed: clicking on the browser's back button does return to the Dashboard.

Summary

• Before this patch: Able to reproduce the issue ✅
• After this patch: issue is resolved ✅

[hellofromTonya]

Patch:

• Confirmed package version numbers match ​https://github.com/WordPress/gutenberg/commit/d14fea64bd9ad9d2d86047936974dbed39a5b5b3 ✅
• Confirmed fix in navigation-link.php matches ​change in Gutenberg ✅
• Confirmed fix in navigation-submenu.php matches ​change in Gutenberg ✅
• Confirmed fix in navigation.php matches ​change in Gutenberg ✅
• Confirmed the browser's back button in Site Editor bug is fixed (​see test report) ✅

Ready for commit 👍

Prepping commit now.

[hellofromTonya]

In 55475:

Editor: Update @wordpress packages for 6.2 Beta 5.

Updates the @wordpress packages to include the following changes:

• Add border radius to off canvas navigation menu items
• Remove border from quick inserter child elements
• Show variant patterns even if there are no patterns for the Query Loop block
• Order initial block items in Navigation with PrivateInserter
• Update: Add descriptions to all panels in the Site Editor's dark side
• Fix typo in template parts description
• Fix: Browse mode descriptions margin
• Fix: Show creation popover on empty page links in the navigation sidebar
• Make sure the directly inserted block in the Nav block is a Page link
• Fix browser history when synchronising state with urls
• Navigation Sidebar: Change the logic about which navigation gets selected for the sidebar
• Fixes extra UI in navigation block inspector
• Renames parent selection boolean param and improves docs
• Widget Importer: Fix Widget Group block imports
• Don't add Post Content layout styles to title in the post editor
• Site editor: Add hover animation to site editor canvas
• Prevent the saving button from showing when renaming templates
• Navigation Block: Fix big spinner
• Navigation: Don't save the level of the link in an attribute
• Focus 1st parent block on block remove, if no previous block is available
• Navigation: Performance: improve params in block_core_navigation_get_most_recently_published_navigation()
• Navigation Block inspector: fix link UI popover opening on links that have a url
• Fix for WP_Theme_JSON_Resolver::get_merged_data()
• Site Editor: Add page details when viewing a specific page.
• Fix site editor sidebar scrollbars
• Fix: Custom link UI does appears outside canvas on the sidebar navigation
• Fix: Make navigation page list load its items on navigation sidebar

References:

• ​Gutenberg's commit for publishing the packages
• ​Gutenberg's commit for `blocks/navigation-link.php` and `blocks/navigation-submenu.php`
• ​Gutenberg's commit for `blocks/navigation.php`

Follow-up to [55441], [55440].

Props ntsekouras, mamaduka, gziolo, costdev, hellofromTonya.
See #57471.

Committed via https://core.trac.wordpress.org/changeset/55475.

[hellofromTonya]

Clearing the workflow.

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/446428841b54f47e5373d6e9723ef7ec24cf11b3

Includes the following changes:

• Site Editor: Move "Add Template"'s descriptions to tooltips
• Update template descriptions with more detail
• Distraction Free Mode: Don't show the metaboxes
• Remove actions from SidebarNavigationScreenWrapper
• Fix: Navigation sidebar shows a wrong submenu popover.
• Fix: Site button metrics
• Fix navigation block off-canvas appender for empty menus
• Style Book: Move iframe to root of content area to support styles that overflow block previews
• Fix navigation block off-canvas appender for empty

Reviewing and testing.

[hellofromTonya]

Patch: ​https://github.com/WordPress/wordpress-develop/pull/4205

• Confirmed all version numbers match ​published package versions ✅
• No issues found in testing ✅

Ready for commit 👍 Prepping commit now.

[hellofromTonya]

In 55496:

Editor: Update @wordpress packages for 6.2 RC1.

Updates the @wordpress packages to include the following changes:

• Site Editor: Move "Add Template"'s descriptions to tooltips
• Update template descriptions with more detail
• Distraction Free Mode: Don't show the metaboxes
• Remove actions from SidebarNavigationScreenWrapper
• Fix: Navigation sidebar shows a wrong submenu popover.
• Fix: Site button metrics
• Fix navigation block off-canvas appender for empty menus
• Style Book: Move iframe to root of content area to support styles that overflow block previews
• Fix navigation block off-canvas appender for empty

Reference:

• ​Package publish commit in Gutenberg

Follow-up to [55475].

Props mamaduka.
See #57471.

Committed via https://core.trac.wordpress.org/changeset/55496.

[hellofromTonya]

Resetting commit keyword.

[hellofromTonya]

6.2. RC1 is happening within the hour. During today's pre-RC1 scrub, it was agreed that 2 issues can continue forward for resolution before RC2:

• Typo in the translatable string ​https://github.com/WordPress/gutenberg/issues/48966
• Heading unexpectedly loses formatting when copy and pasting ​https://github.com/WordPress/gutenberg/issues/48040

Leaving this ticket open.

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/f22a3cbf0cd8f48c7ef800a09b69212a893b99b8

Includes the following changes:

• Comments: Fix 'sprintf requires more than 1 params' error
• Don't offer Classic block as a recovery action when not registered
• Fix typo in the media-categories component
• Hide navigation screen in site editor
• Site editor: Fix non-us spelling in sidebar
• Fix lingering insertion point within template parts
• Navigation Link: Remove color generation code
• Fix settings tab active state border in block inspector
• Fix text alignment in the Site Editor sidebar

Alright, looks good to me.
Note for the Core commit: this also fixes Trac ticket 57883.

Currently reviewing. There is at least 1 fix (so far) that was a bug introduced in 6.1, not in 6.2.

@Mamaduka I've reviewed each of the Gutenberg PRs to determine if each bug / regression was introduced in the 6.2 cycle.

This bug was not introduced in 6.2:

• [Bug] Comments: Fix 'sprintf requires more than 1 params' error ​https://github.com/WordPress/gutenberg/pull/49054 > Introduced in 6.1.1 (not in 6.2) ❌

This fix is removing a PHP function. Was this function introduced in 6.2?

• Navigation Link: Remove color generation code ​https://github.com/WordPress/gutenberg/pull/48927 ❓ > Bug was introduced in 6.2 Beta cycle, but not in RC. And a PHP function is being removed. Need to investigate when this function was introduced into Core.

I also left comments on each of these PRs.

@hellofromtonya,

1. Comments: Fix 'sprintf requires more than 1 params' error - Don't have a strong opinion here. I would love to fix the fatal error, but if it's out of the scope of the RCs, then happy to rever the change.
2. Navigation Link: Remove color generation code - We can also fix this issue without removing the function and applying changes from this area - ​https://github.com/WordPress/wordpress-develop/pull/4234/files#diff-e3c55a4e55bda8c2b88525cb3627924cefcfd1966f936ebb3370020eb296be94R110.

@Mamaduka

@Mamaduka

Navigation Link: Remove color generation code - We can also fix this issue without removing the function and applying changes from this area - ​https://github.com/WordPress/wordpress-develop/pull/4234/files#diff-e3c55a4e55bda8c2b88525cb3627924cefcfd1966f936ebb3370020eb296be94R110.

@Mamaduka Do you when that function was introduced into Core? If during 6.2, then removing is fine. Else, could be deprecated instead if not used and the alternative fix applied.

Comments: Fix 'sprintf requires more than 1 params' error - Don't have a strong opinion here. I would love to fix the fatal error, but if it's out of the scope of the RCs, then happy to revert the change.

This one has a Trac ticket open for it https://core.trac.wordpress.org/ticket/57883. Let's revert it from this PR and continue discussions in that Trac ticket. Sound good? @Mamaduka

@hellofromtonya, definitely not in 6.2. Here is the PR that introduced the function into the Gutenberg plugin - ​https://github.com/WordPress/gutenberg/pull/21075/, so probably WP 5.5-5.6

definitely not in 6.2. Here is the PR that introduced the function into the Gutenberg plugin - ​https://github.com/WordPress/gutenberg/pull/21075, so probably WP 5.5-5.6

Okay thank you @Mamaduka. A hard removal of the function breaks Core's BC (Backwards Compatibility) Promise. It can be deprecated instead or fixed. See my comment here ​https://github.com/WordPress/gutenberg/pull/48927#issuecomment-1468117884

This one has a Trac ticket open for it https://core.trac.wordpress.org/ticket/57883. Let's revert it from this PR and continue discussions in that Trac ticket.

Sorry for misguidance here. @Mamaduka Let's leave this fix on this PR for now but make it a separate commit please. That way its commit can be excluded if there's a decision not to commit it.

• Comments: Fix 'sprintf requires more than 1 params' error - Reverted in ​https://github.com/WordPress/gutenberg/commit/4486a6b22efb62365e2e5976263883558716da8c.
• Navigation Link: Remove color generation code - Feedback addressed in ​https://github.com/WordPress/gutenberg/pull/49064.

Let's leave this fix on this PR for now but make it a separate commit please. That way its commit can be excluded if there's a decision not to commit it.

@hellofromtonya, it needs to be in a separate package update; otherwise build process will overwrite the changes.

Can we include it in RC3 when the decision is reached?

Published package updates ​https://github.com/WordPress/gutenberg/commit/356298f91f5e43d68dda6a770e3e6f8e1aa69f14

[hellofromTonya]

Patch: ​https://github.com/WordPress/wordpress-develop/pull/4234

• Confirmed the package version numbers match the 2 publish releases ([​https://github.com/WordPress/gutenberg/commit/f22a3cbf0cd8f48c7ef800a09b69212a893b99b8 release x.x.9] and ​release x.x.10 ✅
• Confirmed the removed PHP function is restored to avoid breaking BC ✅
• Confirmed the sprintf() bug introduced in 6.1.0 is not in this package update as it is still being discussed ✅

Ready for commit 👍 Prepping commit now.

[hellofromTonya]

In 55542:

Editor: Update @wordpress packages for 6.2 RC2.

Updates the @wordpress packages to include the following changes:

• [Regression] Don't offer Classic block as a recovery action when not registered ​Gutenberg PR 49051 ✅
• [i18n Change] Fix typo in the media-categories component ​Gutenberg PR 49047 ✅
• Hide navigation screen in site editor ​Gutenberg PR 49043 ✅ ​Feature is not ready for 6.2
• [i18n Change] Site editor: Fix non-us spelling in sidebar ​Gutenberg PR 48976 ✅ See Trac #57895.
• [Regression] Site Editor: Fix lingering insertion point within template parts ​Gutenberg PR 48913 ✅ > Regression introduced in 6.2 cycle.
• Navigation Link: Remove color generation code ​Gutenberg PR 48927 and ​Gutenberg PR 49064 ✅
• Fix settings tab active state border in block inspector ​Gutenberg PR 48945 ✅
• Fix text alignment in the Site Editor sidebar ​Gutenberg PR 48959 ✅ Making template descriptions more prominent is part of 6.2.

References:

• ​Packages x.3.9 publish commit
• ​Packages x.3.10 publish commit

Follow-up to [55496].

Props mamaduka, tobifjellner, davidbaumwald, costdev, audrasjb, hellofromTonya.
See #57471.
Fixes #57895.

[hellofromTonya]

Adding dev-feedback for double-signoff to backport [55542] to the 6.2 branch for RC2.

Committed via https://core.trac.wordpress.org/changeset/55542 into trunk.

[SergeyBiryukov]

[55542] looks good to backport to the 6.2 branch.

[hellofromTonya]

In 55548:

Editor: Update @wordpress packages for 6.2 RC2.

Updates the @wordpress packages to include the following changes:

• [Regression] Don't offer Classic block as a recovery action when not registered ​Gutenberg PR 49051 ✅
• [i18n Change] Fix typo in the media-categories component ​Gutenberg PR 49047 ✅
• Hide navigation screen in site editor ​Gutenberg PR 49043 ✅ ​Feature is not ready for 6.2
• [i18n Change] Site editor: Fix non-us spelling in sidebar ​Gutenberg PR 48976 ✅ See Trac #57895.
• [Regression] Site Editor: Fix lingering insertion point within template parts ​Gutenberg PR 48913 ✅ > Regression introduced in 6.2 cycle.
• Navigation Link: Remove color generation code ​Gutenberg PR 48927 and ​Gutenberg PR 49064 ✅
• Fix settings tab active state border in block inspector ​Gutenberg PR 48945 ✅
• Fix text alignment in the Site Editor sidebar ​Gutenberg PR 48959 ✅ Making template descriptions more prominent is part of 6.2.

References:

• ​Packages x.3.9 publish commit
• ​Packages x.3.10 publish commit

Follow-up to [55496].

Props mamaduka, tobifjellner, davidbaumwald, costdev, audrasjb, hellofromTonya.
Reviewed by SergeyBiryukov.
Merges [55542] to the 6.2 branch.
See #57471.
Fixes #57895.

[hellofromTonya]

As of [55542] and [55548], all updates are committed. Resetting the keywords.

The only known remaining issue is #57904, though at this time still needs to be reported upstream for a fix in Gutenberg. Leaving this ticket open for RC3 just in case there are other 6.2 bug and/or regression fixes that need to land.

[hellofromTonya]

RC3 note:
#57929 reported a Navigation Block regression. [55475] included a change that caused this regression. That ​change has been reverted and will be included in the next @wordpress package update in time for RC3.

Committer: Please reference 57929 and include the changeset and PR references for reasoning and historical tracking. Thank you.

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

​https://github.com/WordPress/gutenberg/commit/811da1ab3a91aacd078e71f486e1393e13f72506

Includes the following changes:

• ​https://github.com/WordPress/gutenberg/pull/49126
• ​https://github.com/WordPress/gutenberg/pull/49200

[hellofromTonya]

RC3 Packages Update Patch: ​https://github.com/WordPress/wordpress-develop/pull/4254

• Confirmed all changes are 6.2 regression fixes and okay for RC3:
  • ​Gutenberg PR 49126 reverts change that caused [Navigation] Category/Custom taxonomy links are not searchable in the Link inserter. See #57929 ✅
  • ​Gutenberg PR 49200 hot fix to show the close button in List View on mobile ✅
• Package version numbers match ​the published released packages ✅

Ready for commit 👍 Prepping commit now.

[hellofromTonya]

In 55568:

Editor: Update @wordpress packages for 6.2 RC3.

Updates the @wordpress packages to include the fixes for these regressions introduced in the 6.2 cycle:

• [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter ​Gutenberg PR 49126. See #57929 ✅
• [Regression] Post Editor: List View has no close button on mobile viewports ​Gutenberg PR 49200 ✅

References:

• ​Packages x.3.11 publish commit.

Follow-up to [55548].

Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask.
See #57471.
Fixes #57929.

Committed via https://core.trac.wordpress.org/changeset/55568.

[hellofromTonya]

Marking [55568] for committer double signoff to backport to the 6.2 branch for RC3.

[SergeyBiryukov]

[55568] looks good to backport.

[audrasjb]

GitHub actions are still running, but [55568] looks ready for 6.2 backport.

[hellofromTonya]

In 55570:

Editor: Update @wordpress packages for 6.2 RC3.

Updates the @wordpress packages to include the fixes for these regressions introduced in the 6.2 cycle:

• [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter ​Gutenberg PR 49126. See #57929 ✅
• [Regression] Post Editor: List View has no close button on mobile viewports ​Gutenberg PR 49200 ✅

References:

• ​Packages x.3.11 publish commit.

Follow-up to [55548].

Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask.
Reviewed by SergeyBiryukov, audrasjb.
Merges [55568] to the 6.2 branch.
See #57471.
Fixes #57929.

[hellofromTonya]

With today being the last scheduled RC of the 6.2 cycle, I'm closing this ticket. All known regressions have been committed. Thank you everyone for your contributions!

If more regressions or major bug fixes are needed before the Dry Run next week, this ticket can be reopened and another RC scheduled.

Merged in r55628 / ​https://github.com/WordPress/wordpress-develop/commit/8a6afdd52e572ded7aa350f0d24f40da799596e9