Incorrect $order_by parameter name in personal data exporter and eraser

[SergeyBiryukov]

[42888] / #43440 and [42994] / #43442 introduced these two functions:

• wp_comments_personal_data_exporter()
• wp_comments_personal_data_eraser()

Both functions call get_comments() with 'order_by' => 'comment_ID' as part of the arguments. However, the actual parameter name is orderby.

This does not seem to affect anything in practice, as the incorrect parameter name is just ignored, and the orderby parameter defaults to comment_date_gmt instead, which should result in the same order on a typical installation.

So the order_by parameter here can either be removed or corrected to orderby.

Trac ticket: https://core.trac.wordpress.org/ticket/57700 57700]

[kapilpaul]

patch looks good.

[SergeyBiryukov]

In 55324:

Comments: Use correct orderby parameter name in personal data exporter and eraser.

This ensures that get_comments() is called with the correct parameter name in:

• wp_comments_personal_data_exporter()
• wp_comments_personal_data_eraser()

Follow-up to [42888], [42994].

Props smeunus, kapilpaul, SergeyBiryukov.
Fixes #57700.

Thanks for the PR! Merged in r55324.