WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57714 closed defect (bug) (fixed)

Add missing @since tag for WP_Theme::$default_themes

Reported by: petitphp Owned by: hellofromTonya
Priority: normal Milestone: 6.2
Component: Themes Version: 6.1
Severity: minor Keywords: has-patch commit
Cc: Focuses: docs

Description

Add missing @since tag for Twenty Twenty-Three theme in WP_Theme::$default_themes docblock.

Change History (6)

This ticket was mentioned in ​PR #4072 on ​WordPress/wordpress-develop by ​@petitphp.
4 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/57714

#2 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review → 6.2

#3 follow-up: @hellofromTonya
4 years ago

  • Keywords commit added
  • Owner set to hellofromTonya
  • Status new → reviewing

In #56383, TT3 was introduced in 6.1.0 via [54235] and made the default theme via [54236].

​PR 4072 is ready for commit.

#4 @SergeyBiryukov
4 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 55332:

Docs: Add a @since note about Twenty Twenty-Three for WP_Theme::$default_themes.

Follow-up to [51328], [52941], [54236].

Props petitphp.
Fixes #57714.

​@SergeyBiryukov commented on ​PR #4072:
4 years ago #5

Thanks for the PR! Merged in r55332.

#6 in reply to: ↑ 3 @SergeyBiryukov
4 years ago

Replying to hellofromTonya:

​PR 4072 is ready for commit.

Ah, should have refreshed the tab before committing :) Thanks for the review! I have updated the props for this commit in the Core Props tool on make/core to include the props for you too :)

Note: See TracTickets for help on using tickets.