WordPress.org
Get WordPress

Make WordPress Core

Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#57859 closed defect (bug) (fixed)

CS: Use strict comparison in wp-admin/includes/taxonomy.php

Reported by: ankitmaru's profile ankitmaru Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: has-patch
Focuses: coding-standards Cc:

Description

Coding Standards: Use Yoda Conditions at a few places in the file.

Attachments (1)

57859.diff​ (1.2 KB) - added by dhrumilk 23 months ago.
Diff File added.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in ​PR #4167 on ​WordPress/wordpress-develop by ​@ankitmaru.
23 months ago #1

  • Keywords has-patch added

Yoda conditions fixes

Trac ticket: https://core.trac.wordpress.org/ticket/57859

#2 @SergeyBiryukov
23 months ago

  • Component changed from General to Taxonomy
  • Milestone changed from Awaiting Review to 6.3
  • Summary changed from CS: Use Yoda conditions to CS: Use strict comparison in wp-admin/includes/taxonomy.php

Hi there, thanks for the ticket!

This appears to be about strict comparison rather than Yoda conditions, renaming accordingly.

#3 @SergeyBiryukov
23 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#4 @costdev
23 months ago

  • Keywords changes-requested added

@dhrumilk
23 months ago

Diff File added.

#5 @costdev
23 months ago

  • Keywords changes-requested removed

Thanks @dhrumilk! 57859.diff LGTM! 👍

#6 @SergeyBiryukov
23 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55511:

Coding Standards: Use strict comparison in wp-admin/includes/taxonomy.php.

Follow-up to [4490], [9481], [55190].

Props ankitmaru, costdev, dhrumilk.
Fixes #57859.

​@SergeyBiryukov commented on ​PR #4167:
23 months ago #7

Thanks for the PR! Merged in r55511.

Note: See TracTickets for help on using tickets.