Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#57859 closed defect (bug) (fixed)

CS: Use strict comparison in wp-admin/includes/taxonomy.php

Reported by:	ankitmaru	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	6.3
Component:	Taxonomy	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	coding-standards

Description

Coding Standards: Use Yoda Conditions at a few places in the file.

Attachments (1)

57859.diff (1.2 KB ) - added by dhrumilk 3 years ago.: Diff File added.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in PR #4167 on WordPress/wordpress-develop by @ankitmaru.

3 years ago #1

Keywords has-patch added

Yoda conditions fixes

Trac ticket: https://core.trac.wordpress.org/ticket/57859

#2 @SergeyBiryukov
3 years ago

Component General → Taxonomy
Milestone Awaiting Review → 6.3
Summary CS: Use Yoda conditions → CS: Use strict comparison in wp-admin/includes/taxonomy.php

Hi there, thanks for the ticket!

This appears to be about strict comparison rather than Yoda conditions, renaming accordingly.

#3 @SergeyBiryukov
3 years ago

Owner set to SergeyBiryukov
Status new → accepted

#4 @costdev
3 years ago

Keywords changes-requested added

@dhrumilk
3 years ago

Attachment 57859.diff added

Diff File added.

#5 @costdev
3 years ago

Keywords changes-requested removed

Thanks @dhrumilk! 57859.diff LGTM! 👍

#6 @SergeyBiryukov
3 years ago

Resolution → fixed
Status accepted → closed

Coding Standards: Use strict comparison in wp-admin/includes/taxonomy.php.

Follow-up to [4490], [9481], [55190].

Props ankitmaru, costdev, dhrumilk.
Fixes #57859.

@SergeyBiryukov commented on PR #4167:

3 years ago #7

Thanks for the PR! Merged in r55511.

Note: See TracTickets for help on using tickets.

Download in other formats: