Make WordPress Core

Opened 14 months ago

Closed 11 months ago

Last modified 11 months ago

#58033 closed defect (bug) (fixed)

Twenty Twenty: Quote block's paragraph does not inherit custom letter spacing in the editor

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.2
Component: Bundled Theme Keywords: has-patch has-testing-info commit
Focuses: css Cc:

Description (last modified by sabernhardt)

Steps to reproduce the issue :-

  1. Activate Twenty Twenty theme.
  2. Choose Quote block.
  3. Apply letter spacing to Quote block.

You can able to see the given letter spacing is applied only on the citation and not for paragraph, whereas other side for user it is working fine and given letter spacing is applied to both.

I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/p70Y4fJn2jV8kmL6bWhg

Attachments (1)

58033.patch (970 bytes) - added by nidhidhandhukiya 14 months ago.
After applying this solution the issue is resolved.

Download all attachments as: .zip

Change History (14)

@nidhidhandhukiya
14 months ago

After applying this solution the issue is resolved.

#1 @shiponkarmakar
14 months ago

  • Keywords has-patch needs-testing needs-unit-tests added

This ticket was mentioned in Slack in #core-test by shiponkarmakar. View the logs.


14 months ago

#3 @ironprogrammer
14 months ago

  • Keywords needs-unit-tests removed

Thank you for the report, @nidhidhandhukiya!

During test triage, several contributors were able to confirm this issue, and verify that it affects TT1 as well. Hopefully a related ticket will follow on to this one.

(And thanks for the initial triage, @shiponkarmakar! Note that I'm removing needs-unit-tests as that isn't typically required for CSS adjustments like this.)

#4 @ironprogrammer
14 months ago

  • Keywords has-testing-info added

#5 @sabernhardt
14 months ago

  • Description modified (diff)
  • Focuses css added
  • Milestone changed from Awaiting Review to 6.3
  • Summary changed from Twenty Twenty theme - quote block does not inherit custom letter spacing for editor side. to Twenty Twenty: Quote block's paragraph does not inherit custom letter spacing in the editor

More testing is welcome, but I think the patch is ready.

  • It only changes styles in the block editor for the Quote block.
  • The paragraph inherits the letter spacing properly, matching the front.

#6 @pooja1210
14 months ago

Hi,

Tested the patch and it's working. Letter spacing for the quote block title in the editor is visible after the patch.

Before: https://prnt.sc/j_-hlWhuKUFu

After adding patch: https://prnt.sc/Cij2PzL9VCjE

Test Environment
Theme: Twenty Twenty
WordPress: 6.2

#7 @ugyensupport
14 months ago

Twenty Twenty: Quote block's paragraph does not inherit custom letter spacing in the editor

Description

Quote block's paragraph does not inherit custom letter spacing in the editor, You can able to see the given letter spacing is applied only on the citation and not for paragraph, whereas other side for user it is working fine and given letter spacing is applied to both as mentioned by Nidhi Dhandhukiya.

Environment

  • WordPress: 6.2
  • PHP: 7.4.13
  • Server: Apache/2.4.10 (Debian)
  • Database: mysqli (Server: 5.5.59-MariaDB-1~wheezy / Client: 5.5.62)
  • Browser: Chrome 111.0.0.0 (macOS)
  • Theme: Twenty Twenty 2.2
  • MU-Plugins: None activated
  • Plugins:
    • Gutenberg 15.4.0
    • WordPress Beta Tester 3.3.7

Steps to Reproduce

  1. Activate Twenty Twenty theme.
  2. Choose Quote block.
  3. Apply letter spacing to Quote block.
  4. 🐞 Bug occurs.

Expected Results

  1. ✅ After applying Nidhi Dhandhukiya's solution it works smoothly.

https://core.trac.wordpress.org/ticket/58033#58033.patch

Actual Results

  1. ❌ Looking forward to see this fix in our future release.

#8 @pouicpouic
13 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/ticket/56538

Environment

  • OS: Windows 10
  • Web Server: apache
  • PHP: 8.0.0
  • WordPress: 6.3-alpha-55661
  • Browser: Chrome 112.0.5615.138
  • Theme: Twenty Twenty
  • Active Plugins:
    • WordPress Beta Tester 3.3.7

Actual Results

  • ✅ Issue resolved with patch.

Additional Notes

  • Any additional details worth mention.

#9 @poena
11 months ago

  • Keywords commit added

Thank you for reporting, working on, and testing this issue.
I have tested the patch on WordPress 6.3-alpha (MacOS, Chrome), and it works well.

#10 @audrasjb
11 months ago

  • Keywords needs-testing removed

Thanks everyone for working on this and thanks Carolina for testing.
Self assigning for commit consideration.

#11 @audrasjb
11 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#12 @audrasjb
11 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55967:

Twenty Twenty: Inherit Quote block's paragraph custom letter spacing in the editor.

Props nidhidhandhukiya, sabernhardt, pooja1210, ugyensupport, pouicpouic, poena.
Fixes #58033.

#13 @sabernhardt
11 months ago

#56139 was marked as a duplicate.

Note: See TracTickets for help on using tickets.