For echo the translated string, use _e() instead of __()

[mujuonly]

If you want to echo the translated string, then you will be using _e() and when you just want to have the translated string, then you will be using __().

Used echo __( 'Search Media' ) in /wp-admin/includes/media.php

To echo the translated string, then you will be using _e()

Trac ticket: https://core.trac.wordpress.org/ticket/58138

[audrasjb]

Hello, thanks for the ticket & patch!

Good point.
Also, I think the translation string should include the : character. In some locales, this character has to be translatable. For example we need a non-breaking space before : in fr_FR.

[vladytimy]

Good catch

Also, I think the translation string should include the : character.

+1 on this part. Punctuation should always be included in the translation string.

[mujuonly]

@vladytimy @audrasjb The current code is like echo __( 'Search Media' ) . ':';, so it should be like _e( 'Search Media:' ); right.?

[audrasjb]

Yeah that's the idea :)

Punctuation should always be included in the translation string

Trac ticket: https://core.trac.wordpress.org/ticket/58138

[mujuonly]

@audrasjb Updated with a PR

[krupalpanchal]

​PR LGTM

@mujuonly Also check if the same occurrence is not again in the file(s).

[mukesh27]

Hi there! thanks for ticket and PR!

The PR 4333 ready to go.

Assign to @audrasjb for final review and commit.

[audrasjb]

In 55684:

I18N: Use correct translation function in wp-admin/includes/media.php.

This changeset replaces echo __() with the appropriate _e() function. It also ensures the punctuation is included in the translation string.

Props mujuonly, audrasjb, vladytimy, krupalpanchal, mukesh27.
Fixes #58138.

Committed in https://core.trac.wordpress.org/changeset/55684