#58334 closed defect (bug) (fixed)
Typo in a comment in Bulk_Upgrader_Skin::header() and ::footer()
Reported by: | kamplugins | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch commit |
Focuses: | coding-standards | Cc: |
Description
I found a grammatical mistake. This is a small issue, but I think it should be fixed.
Issue found in the following lines:
Change History (15)
This ticket was mentioned in PR #4464 on WordPress/wordpress-develop by @kamplugins.
16 months ago
#1
- Keywords has-patch added
#2
@
16 months ago
- Keywords changes-requested added
- Milestone changed from Awaiting Review to 6.3
@kamplugins Approved PR from my end, pending the changes from @costdev.
This ticket was mentioned in PR #4465 on WordPress/wordpress-develop by madhusudan-hub.
16 months ago
#3
Indentation and Spacing Issue fixed.
Trac ticket: https://core.trac.wordpress.org/ticket/58334
This ticket was mentioned in Slack in #core-upgrade-install by pbiron. View the logs.
16 months ago
16 months ago
#7
Hi @mamun94! Are you available to update this pull request with the suggested changes above? 🙂
@kamplugins commented on PR #4464:
16 months ago
#8
Hi,
@costdev Changed the suggested issue updated. 🙂🙂
#9
@
16 months ago
- Keywords commit added; changes-requested removed
Feedback on the PR has been addressed. Adding for commit
consideration.
#10
@
16 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 55823:
#11
@
16 months ago
- Summary changed from Found a grammatical mistake to Typo in a comment in Bulk_Upgrader_Skin::header() and ::footer()
@SergeyBiryukov commented on PR #4464:
16 months ago
#12
Thanks for the PR! Merged in r55823.
#13
follow-up:
↓ 14
@
16 months ago
I made a global search and it gave me a huge list of candidates. Here only a few of those that need to be corrected:
\src\wp-admin\includes\class-plugin-upgrader.php
Line 241: Cleanup our hooks, in case something else does a upgrade on this connection.
\src\wp-admin\includes\class-theme-upgrader.php
Line 490: Cleanup our hooks, in case something else does a upgrade on this connection.
\src\wp-admin\includes\class-wp-filesystem-base.php
Line 401: * Converts *nix-style file permissions to a octal number.
\src\wp-admin\includes\update-core.php
Line 1499: If a error occurs partway through this final step, keep the error flowing through, but keep process going.
\src\wp-admin\update-core.php
Line 1022: Force a update check when requested.
Is it worth to open another ticket for that?
Fixed grammatical mistakes.
Trac ticket: https://core.trac.wordpress.org/ticket/58334