Use register_block_type_from_metadata in register_core_block_types_from_metadata

[spacedmonkey]

In register_core_block_types_from_metadata function, register_block_type is called. This does a file_exists check and then calls register_block_type_from_metadata. However, register_block_type_from_metadata can be called directly with the same effect. This saves around 21 files exists checks and results in improved performance.

[nihar007]

Replaced register_block_type with register_block_type_from_metadata

[mukesh27]

Thanks @nihar007 for the Patch!

Your patch has PHPCS error. Instead of arrange in single line just replace register_block_type with register_block_type_from_metadata function.

[nihar007]

Thanks for your feedback.
I got it.
I am patching once again after fixing this.

[nihar007]

This time I followed pre-defined coding standards

Trac ticket: https://core.trac.wordpress.org/ticket/58342

[mukesh27]

Thanks @nihar007 and @sudipatel007 for the patch.

[spacedmonkey]

I would love the thoughts of @gziolo @youknowriad on this change.

[gziolo]

The changes proposed make sense. In retrospect, the direct call seems like a reasonable choice in WordPress Core.

[spacedmonkey]

@gziolo Would there ever be a case where there are core blocks without block.json? I am guessing not.

I am good to commit this then?

[gziolo]

Good to commit. All core blocks need to have block.json. It's also optimized behind the scenes, and all core blocks have block.json transformed into a single PHP file during the build process to avoid reading and parsing all individual JSON files.

[spacedmonkey]

Making this as ready for commit.

This is not just a code quality change. This change removes 31 calls to file exists, so this change has a performance benefit. Flagging the performance lead @flixos90 for review.

[spacedmonkey]

In 55879:

Editor: Use register_block_type_from_metadata in register_core_block_types_from_metadata.

Use register_block_type_from_metadata in register_core_block_types_from_metadata function instead of register_block_type. This saves an unnecessary call to file_exists in register_block_type as core block files will always exist.

Props nihar007, spacedmonkey, mukesh27, gziolo, sudipatel007.
Fixes #58342.

Committed.