Opened 16 months ago
Closed 16 months ago
#58372 closed defect (bug) (fixed)
Improve formatting of some SQL queries for readability
Reported by: | umeshmcakadi | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | minor | Version: | |
Component: | Database | Keywords: | has-patch |
Focuses: | administration, coding-standards | Cc: |
Description
In wp-admin/export.php in function export_date_options query should be in more readable format for that it must be start in the same line we use the double quote. Please see my patch file for that.
Attachments (3)
Change History (10)
#2
@
16 months ago
Hi @mukesh27,
I have uploaded another patch file named wp_prepare_code_format.diff for all possible fix for this.
Thanks
#3
follow-up:
↓ 4
@
16 months ago
Hi @umeshmcakadi
Welcome to core trac.
There are two more instances found in the user.php
file on L1272 & L1303. Also, check once again if you find other instances and update in the patch.
#4
in reply to:
↑ 3
@
16 months ago
Okay I will check for that as well and add patch again
Replying to krupalpanchal:
Hi @umeshmcakadi
Welcome to core trac.
There are two more instances found in the
user.php
file on L1272 & L1303. Also, check once again if you find other instances and update in the patch.
#6
@
16 months ago
- Component changed from Export to Database
- Milestone changed from Awaiting Review to 6.3
- Summary changed from Code Format to Improve formatting of some SQL queries for readability
Hi there, welcome to WordPress Trac! Thanks for the ticket, moving to 6.3 for review.
Updating the component, as it's not only about wp-admin/export.php
now.
Hi there! thanks for ticket and patch!
Can you check other instance of query format and correct it in single patch?