Opened 3 years ago
Closed 3 years ago
#58436 closed defect (bug) (fixed)
Emoji: Extraneous sprintf() present in _print_emoji_detection_script()
| Reported by: | westonruter | Owned by: | westonruter |
|---|---|---|---|
| Priority: | low | Milestone: | 6.3 |
| Component: | Emoji | Version: | 5.9 |
| Severity: | trivial | Keywords: | has-patch |
| Cc: | Focuses: |
Description
In r52132 for #44632 I erroneously included a sprintf() without any arguments:
// src/wp-includes/embed.php $output = wp_get_inline_script_tag( file_get_contents( sprintf( ABSPATH . WPINC . '/js/wp-embed' . wp_scripts_get_suffix() . '.js' ) ) );
And:
// src/wp-includes/formatting.php wp_print_inline_script_tag( sprintf( 'window._wpemojiSettings = %s;', wp_json_encode( $settings ) ) . file_get_contents( sprintf( ABSPATH . WPINC . '/js/wp-emoji-loader' . wp_scripts_get_suffix() . '.js' ) ) );
I fixed the former case in r52151 but I missed the latter.
Change History (5)
This ticket was mentioned in PR #4529 on WordPress/wordpress-develop by @westonruter.
3 years ago
#1
- Keywords has-patch added
#3
@
3 years ago
- Keywords fixed-major added
- Resolution fixed
- Status closed → reopened
Reopening for 6.2.3 consideration.
@westonruter commented on PR #4529:
3 years ago
#4
Committed to trunk in r55875.
Note:
See TracTickets
for help on using tickets.
Trac ticket: https://core.trac.wordpress.org/ticket/58436