#58468 closed defect (bug) (fixed)
Add missing param description to `update_menu_item_cache` in `wp_get_nav_menu_items()`.
Reported by: | audrasjb | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 6.1 |
Component: | Menus | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Because update_menu_item_cache
parameter doesn't have any description in this function, the wp_get_nav_menu_items()
documentation page on DevHub fallbacks to get_post()
params descriptions… which fallbacks to parse_query()
.
In parse_query()
, the update_menu_item_cache
param is set to false
by default, so wp_get_nav_menu_items()
ends up with a value of false
by default, which is wrong since wp_get_nav_menu_items()
overrides this parameter to set it to true
by default.
Remediation: add update_menu_item_cache
parameter to wp_get_nav_menu_items()
’s docblock, and indicates that it is set to true
by default.
See https://developer.wordpress.org/reference/functions/wp_get_nav_menu_items/ (click on the More Arguments from get_posts( ... $args )
accordion link).
Props @matmoe for reporting this issue in a DevHub comment.
Change History (6)
This ticket was mentioned in PR #4558 on WordPress/wordpress-develop by @audrasjb.
20 months ago
#1
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/58468