Make WordPress Core

#58509 closed defect (bug) (fixed)

Twenty Fourteen: Default Button Color Issue in Sidebar & Button Color Issue on Hover in Primary Sidebar & Footer Widget

Reported by: shailu25's profile shailu25 Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 5.8
Component: Bundled Theme Keywords: has-patch has-screenshots commit
Focuses: css Cc:

Description

In Twenty Fourteen theme when we add button in Primary Sidebar / Content Sidebar / Footer Widget there is button color issue.

Steps to Reproduce the Issue :

  • Activate Twenty Fourteen theme.
  • Add Button in Primary Sidebar , Content Sidebar & Footer Widget & Update it

You can able to see that Button Color Issue in Content Sidebar button & Button Color issue on Hover in Primary Sidebar & Footer Widget button.

I have attached video for better understanding.

Video Link: https://drive.google.com/file/d/1n4SjEfJQPw3fsSTe5lklx6L6ca9n1C00/view

Attachments (13)

58509.patch (803 bytes) - added by shailu25 12 months ago.
Patch Added
Before-patch-content-sidebar-button-color.png (85.4 KB) - added by shailu25 12 months ago.
Before Patch - Sidebar Button Color
After-patch-content-sidebar-button-color.png (77.1 KB) - added by shailu25 12 months ago.
After Patch - Content Sidebar Button Color
Before-patch-primary-sidebar-button-color-on-hover.png (90.4 KB) - added by shailu25 12 months ago.
Before Patch - Primary Sidebar Button Color
After-patch-primary-sidebar-button-hover-color.png (199.3 KB) - added by shailu25 12 months ago.
After Patch - Primary Sidebar Button Color on Hover
Before-patch-footer-widget-button-color-on-hover.png (61.9 KB) - added by shailu25 12 months ago.
Before Patch - Footer Widget Button Color on hover
After-patch-footer-widget-button-color-on-hover.png (80.8 KB) - added by shailu25 12 months ago.
After Patch - Footer Widget Button Color on hover
58509.1.patch (846 bytes) - added by sabernhardt 12 months ago.
After-patch-Sidebar-button-default.png (71.1 KB) - added by shailu25 12 months ago.
After Patch - Content Sidebar Button Color
After-patch-primary-sidebar-button-color-onhover.png (66.2 KB) - added by shailu25 12 months ago.
After Patch - Primary Sidebar Button Color On Hover
After-patch-download-button-link-color.png (56.0 KB) - added by shailu25 12 months ago.
After Patch Download Button Color
after-patch-footer-button-color-on-hover.png (63.8 KB) - added by shailu25 12 months ago.
After Patch Footer Button Color On Hover
After-patch-download-button-color-on-hover-and-default.png (78.9 KB) - added by shailu25 12 months ago.
After Patch Download Button Color

Download all attachments as: .zip

Change History (21)

@shailu25
12 months ago

Patch Added

@shailu25
12 months ago

Before Patch - Sidebar Button Color

@shailu25
12 months ago

After Patch - Content Sidebar Button Color

@shailu25
12 months ago

Before Patch - Primary Sidebar Button Color

@shailu25
12 months ago

After Patch - Primary Sidebar Button Color on Hover

@shailu25
12 months ago

Before Patch - Footer Widget Button Color on hover

@shailu25
12 months ago

After Patch - Footer Widget Button Color on hover

#1 @shailu25
12 months ago

  • Keywords has-patch added

#2 @sabernhardt
12 months ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 6.3

Thanks for the report and patch!

The same situation occurs with File block download links in widget areas.

Also, Twenty Fourteen has a separate blocks.css stylesheet for block styles, so the corrections probably should be in that file.

#3 @sabernhardt
12 months ago

  • Keywords needs-testing added
  • Version changed from 6.2.2 to 5.8

@shailu25
12 months ago

After Patch - Content Sidebar Button Color

@shailu25
12 months ago

After Patch - Primary Sidebar Button Color On Hover

@shailu25
12 months ago

After Patch Download Button Color

@shailu25
12 months ago

After Patch Footer Button Color On Hover

#4 @shailu25
12 months ago

Last edited 12 months ago by shailu25 (previous) (diff)

@shailu25
12 months ago

After Patch Download Button Color

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


12 months ago

#6 @kapilpaul
12 months ago

Tested with https://core.trac.wordpress.org/attachment/ticket/58509/58509.1.patch. The patch looks good to me and this solved the issue.

#7 @mukesh27
11 months ago

  • Keywords has-screenshots commit added; needs-testing removed

Thanks for the ticket!

@sabernhardt patch 58509.1.patch address the color issue for button and file button in all context.

commit added keyword. Ping @audrasjb for review.

#8 @audrasjb
11 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 56116:

Twenty Fourteen: Fix text color issue on Button block hover.

This fixes a text color issue when hovering Button blocks located on sidebars or widgets.

Props shailu25, sabernhardt, mukesh27.
Fixes #58509.

Note: See TracTickets for help on using tickets.