#58570 closed task (blessed) (fixed)
Add Post Template layout fallback styles for classic themes
Reported by: | isabel_brison | Owned by: | isabel_brison |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 6.3 |
Component: | Editor | Keywords: | gutenberg-merge has-patch |
Focuses: | Cc: |
Description
Fallback styles need to be added to class-wp-theme-json.php
for classic themes to display the correct Post Template layout. This is necessary due to the changes from https://github.com/WordPress/gutenberg/pull/49050.
Depends on #58554 for the grid layout styles.
Change History (7)
This ticket was mentioned in PR #4639 on WordPress/wordpress-develop by @isabel_brison.
16 months ago
#1
- Keywords has-patch added
@isabel_brison commented on PR #4639:
16 months ago
#2
Do these unit tests need to be ported over? Or will they be taken care of in #4625?
I think I need to commit #4625 first and then rebase this one, because the tests are still passing without updating the string.
@isabel_brison commented on PR #4639:
16 months ago
#3
Hmmm, looks like the fallback styles are not being output yet, because the packages haven't been updated, so Post Template block still doesn't have spacing support, so this check fails 😞
This is a small PR so I guess it can wait until the packages are updated, and once they are I can update the unit test string.
@mikeschroder commented on PR #4639:
16 months ago
#4
That approach makes sense to me as well!
#5
@
16 months ago
- Type changed from enhancement to task (blessed)
Converting to a task as this can ship after beta 1 is released.
Trac ticket: https://core.trac.wordpress.org/ticket/58570
Adds the Post Template fallback styles for classic themes from https://github.com/WordPress/gutenberg/pull/49050, following the same logic already used for the Columns block.