Opened 6 months ago
Last modified 5 months ago
#58608 new defect (bug)
Twenty Twenty-One: Text color is not reflected when having background color
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-screenshots has-testing-info |
Focuses: | ui, css | Cc: |
Description
Originally reported as a Gutenberg issue: https://github.com/WordPress/gutenberg/issues/51828
In #52129, there was a problem with text being obscured in dark mode. The approach taken to solve this was to override the text color with var(--table--has-background-text-color)
variable if it had a background color.
Later, however, the table block now supports text color and can be set to any text color.
The text color changed by block support is not applied because it is overwritten by the color of the var(--table--has-background-text-color)
variable mentioned above.
Attachments (2)
Change History (5)
#2
@
6 months ago
- Focuses ui css added
- Keywords has-screenshots has-testing-info added
Test Report for https://core.trac.wordpress.org/attachment/ticket/58608/58608.diff Patch.
Backend:
=======
Before patch: https://prnt.sc/Uhz7lE9AgVfK
After patch: https://prnt.sc/4qrJkX_3wIVU
Front end:
=========
Before patch: https://prnt.sc/CWk7YDCTMN7T
After patch: https://prnt.sc/1WuyLxZK8Ky6
https://core.trac.wordpress.org/attachment/ticket/58608/58608.diff Patch is Working fine
#3
@
5 months ago
Test Report
Patch tested: https://core.trac.wordpress.org/attachment/ticket/58608/58608.diff
Environment
- OS: macOS 12.4
- Web Server: Nginx
- PHP: 7.4.33
- WordPress: 6.3-alpha-55505-src
- Browser: Chrome
- Theme: Twenty-twenty-one
ScreenCast
Before
- Backend: https://prnt.sc/Zqv5GC2lypkA
- Frontend: https://prnt.sc/IxPFdeS_PhcE
After
- Backend: https://prnt.sc/tAhxLMk4dQH3
- Frontend: https://prnt.sc/Li07XVfwDrlp
Actual Results
- The patch is working as expected✅
In the striped table, if a background color is set, it is overwritten by the text color of the theme