Make WordPress Core

Opened 11 months ago

Last modified 10 months ago

#58608 new defect (bug)

Twenty Twenty-One: Text color is not reflected when having background color

Reported by: wildworks's profile wildworks Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots has-testing-info
Focuses: ui, css Cc:

Description

Originally reported as a Gutenberg issue: https://github.com/WordPress/gutenberg/issues/51828

In #52129, there was a problem with text being obscured in dark mode. The approach taken to solve this was to override the text color with var(--table--has-background-text-color) variable if it had a background color.
Later, however, the table block now supports text color and can be set to any text color.
The text color changed by block support is not applied because it is overwritten by the color of the var(--table--has-background-text-color) variable mentioned above.

Attachments (2)

striped-table.png (72.2 KB) - added by wildworks 11 months ago.
In the striped table, if a background color is set, it is overwritten by the text color of the theme
58608.diff (1.9 KB) - added by shailu25 11 months ago.
Patch added

Download all attachments as: .zip

Change History (5)

@wildworks
11 months ago

In the striped table, if a background color is set, it is overwritten by the text color of the theme

@shailu25
11 months ago

Patch added

#1 @shailu25
11 months ago

  • Keywords has-patch added

#2 @harshgajipara
11 months ago

  • Focuses ui css added
  • Keywords has-screenshots has-testing-info added

#3 @alvitazwar052
10 months ago

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/58608/58608.diff

Environment

  • OS: macOS 12.4
  • Web Server: Nginx
  • PHP: 7.4.33
  • WordPress: 6.3-alpha-55505-src
  • Browser: Chrome
  • Theme: Twenty-twenty-one

ScreenCast

Before

After

Actual Results

  • The patch is working as expected✅
Note: See TracTickets for help on using tickets.