Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#59010 closed enhancement (fixed)

Code Styling: Add missing star to make comment a docblock comment

Reported by: dmsnell Owned by: jorbin
Priority: normal Milestone: 6.4
Component: HTML API Version: 6.4
Severity: normal Keywords: has-patch
Cc: Focuses: coding-standards

Description

No explanation needed; this is a fix for something that was missed during multiple rounds of reviews and CI checks.

Change History (6)

This ticket was mentioned in ​PR #4976 on ​WordPress/wordpress-develop by ​@dmsnell.


3 years ago
#1

Trac Ticket: #59010

No explanation needed; this is a fix for something that was missed during multiple rounds of reviews and CI checks.

#2 @dmsnell
3 years ago

This patch has already been proposed in the ​ Gutenberg backport of the HTML Processor so if we can fast-track it I'd love to avoid keeping two separate versions of the code for any longer than we have to.

I've pushed it in Gutenberg to avoid delaying the backport PR unnecessarily: this adds a missing * on the docblock for an internal private method on the HTML Processor.

Last edited 3 years ago by dmsnell (previous) (diff)

#3 @jorbin
3 years ago

  • Milestone Awaiting Review → 6.4
  • Owner set to jorbin
  • Status new → assigned

Follow up to #58918 and [56363]. Landing this now.

#4 @jorbin
3 years ago

  • Resolution → fixed
  • Status assigned → closed

In 56376:

HTML API: Fix missing * for docblock.

Follow up to [56363].

Props dmsnell.
See #58918. Fixes #59010.

#5 @dmsnell
3 years ago

thanks @jorbin !

Note: See TracTickets for help on using tickets.