WordPress.org
Get WordPress

Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#59010 closed enhancement (fixed)

Code Styling: Add missing star to make comment a docblock comment

Reported by: dmsnell's profile dmsnell Owned by: jorbin's profile jorbin
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: HTML API Keywords: has-patch
Focuses: coding-standards Cc:

Description

No explanation needed; this is a fix for something that was missed during multiple rounds of reviews and CI checks.

Change History (6)

This ticket was mentioned in ​PR #4976 on ​WordPress/wordpress-develop by ​@dmsnell.
18 months ago #1

Trac Ticket: #59010

No explanation needed; this is a fix for something that was missed during multiple rounds of reviews and CI checks.

#2 @dmsnell
18 months ago

This patch has already been proposed in the ​ Gutenberg backport of the HTML Processor so if we can fast-track it I'd love to avoid keeping two separate versions of the code for any longer than we have to.

I've pushed it in Gutenberg to avoid delaying the backport PR unnecessarily: this adds a missing * on the docblock for an internal private method on the HTML Processor.

Last edited 18 months ago by dmsnell (previous) (diff)

#3 @jorbin
18 months ago

  • Milestone changed from Awaiting Review to 6.4
  • Owner set to jorbin
  • Status changed from new to assigned

Follow up to #58918 and [56363]. Landing this now.

#4 @jorbin
18 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 56376:

HTML API: Fix missing * for docblock.

Follow up to [56363].

Props dmsnell.
See #58918. Fixes #59010.

#5 @dmsnell
18 months ago

thanks @jorbin !

Note: See TracTickets for help on using tickets.