units missing in media details

[Presskopp]

Some units are missing which have been there before, see #39667

Length and Dimensions have no units anymore. I don't know since when, just found out using v6.3

This is the view you get after clicking a video in media gallery (Attachment Details) and then click on "Edit more details"

[audrasjb]

Hello,

It seems that [43633] and [44481] (from #39667) only improved media-template.php and not media.php where I believe the strings you mentioned come from.

See ​https://github.com/WordPress/wordpress-develop/blob/6.3/src/wp-admin/includes/media.php#L1665

[Presskopp]

btw: same issue in attachment details view.

The specific 'Dimensions' are generated in
​https://github.com/WordPress/wordpress-develop/blob/6.3/src/wp-admin/includes/media.php#L3304

[Presskopp]

added screenshots after patch

[joedolson]

Noting that in the modal, the text is "num by num pixels", and this patch makes the non-modal view "num x num px". For consistency and clarity, let's set both of them to the current string, using plain text and unabbreviated terminology.

[joedolson]

Patch re-using existing "length by height pixels" string

[joedolson]

Updated the patch to re-use the existing string for giving file dimensions.

[shailu25]

Test Report

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/59009/59009.2.diff

Environment:

WordPress - 6.5.3
OS - Windows
Browser - Firefox
Theme: Twenty Seventeen
PHP - 8.1.23

Actual Results:

• Length and Dimensions units are showing in Attachment Details & Edit More Details(Click On Edit More Details) Screen with patch.✅

[shailu25]

Attachment Details - Before Patch

[shailu25]

Edit More Details Screen - Before Patch

[shailu25]

Attchment Details Units - After Patch

[shailu25]

Edit More Details Screen Units - After Patch

[joedolson]

Thanks for testing @shailu25!

I think this is good to go; marking for commit.

[joedolson]

In 58217:

Media: Add missing units for length and dimensions in media library.

Include explicit units for media length and dimensions in attachment modal and media details screen.

Props Presskopp, joedolson, shailu25, audrasjb.
Fixes #59009.