Make WordPress Core

Opened 9 months ago

Last modified 9 months ago

#59009 new defect (bug)

units missing in media details

Reported by: presskopp's profile Presskopp Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots has-patch
Focuses: Cc:

Description

Some units are missing which have been there before, see #39667

Length and Dimensions have no units anymore. I don't know since when, just found out using v6.3

This is the view you get after clicking a video in media gallery (Attachment Details) and then click on "Edit more details"

Attachments (5)

units-missing.png (10.7 KB) - added by Presskopp 9 months ago.
details.png (65.2 KB) - added by Presskopp 9 months ago.
59009.diff (1.8 KB) - added by Presskopp 9 months ago.
units_details.png (11.8 KB) - added by Presskopp 9 months ago.
units.png (10.9 KB) - added by Presskopp 9 months ago.

Download all attachments as: .zip

Change History (9)

#1 @audrasjb
9 months ago

Hello,

It seems that [43633] and [44481] (from #39667) only improved media-template.php and not media.php where I believe the strings you mentioned come from.

See https://github.com/WordPress/wordpress-develop/blob/6.3/src/wp-admin/includes/media.php#L1665

#2 @Presskopp
9 months ago

btw: same issue in attachment details view.

The specific 'Dimensions' are generated in
https://github.com/WordPress/wordpress-develop/blob/6.3/src/wp-admin/includes/media.php#L3304

@Presskopp
9 months ago

@Presskopp
9 months ago

#3 @Presskopp
9 months ago

  • Keywords has-patch added; needs-patch removed

@Presskopp
9 months ago

#4 @Presskopp
9 months ago

added screenshots after patch

Note: See TracTickets for help on using tickets.