Opened 7 weeks ago
Last modified 9 days ago
#59033 new defect (bug)
Credits: Focus outline is cut off
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | trivial | Version: | |
Component: | Help/About | Keywords: | good-first-bug has-patch |
Focuses: | Cc: |
Description
On the credits page, when I focus on the Noteworthy Contributors user, the outline is cut off.
On Windows OS, the result is as follows:
- Chrome cuts the left side to the outline.
- Firefox displays a portion of the outline above the avatar image.
Attachments (5)
Change History (13)
#1
@
7 weeks ago
- Component changed from General to Help/About
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to 6.4
- Severity changed from normal to trivial
This ticket was mentioned in PR #4986 on WordPress/wordpress-develop by @ivanzhuck.
7 weeks ago
#2
- Keywords has-patch added; needs-patch removed
Corrected the CSS styles
#3
@
7 weeks ago
Css fix to the focus outline.
Code here:
.about__section a:active, .about__section a:focus, .about__section a:hover { color: var(--accent-1); text-decoration: none; outline: 1px solid #2271b1; }
#4
@
7 weeks ago
I think the whole card of contributor is a link (picture + name). So the focus outline should be around them instead of framing only name. I released a fix for it, please review.
#5
@
6 weeks ago
I got the chance to test this issue and the fixes by this patch look good to me. https://github.com/WordPress/wordpress-develop/pull/4986
Test Report
Patch tested: https://github.com/WordPress/wordpress-develop/pull/4986
Env
- WordPress - 6.4-alpha-20230817.203813
- Web Server: Nginx
- Chrome Version - 115
- Safari Version - 15.4
- Firefox Version - 116.02
- Opera Version - 101
- OS - macOS
- Theme: Twenty Twenty-Three
- PHP - 7.4.0
- Active Plugin - None
Test result
Works fine on the credit page now. Tested on macOS Chrome, Firefox, Safari, and Opera.
After the patch-
Chrome:
Firefox:
Opera:
Safari:
Chrome