Make WordPress Core

Opened 5 weeks ago

Last modified 3 weeks ago

#59108 reopened defect (bug)

Preserve block style variations when securing theme json

Reported by: dean's profile dean Owned by: isabel_brison's profile isabel_brison
Milestone: 6.3.2 Priority: normal
Severity: normal Version: 6.3
Component: Editor Keywords: has-patch has-unit-tests dev-feedback
Focuses: Cc:


I'd like to sync a GB PR that fixes an issue where block style variations are not preserved when securing theme json


Change History (6)

This ticket was mentioned in PR #5013 on WordPress/wordpress-develop by @dsas.

5 weeks ago

  • Keywords has-patch has-unit-tests added

Valid and safe block style variations were being removed by WP_Theme_JSON::remove_insecure_properties when securing the theme.json. When this was a problem varied depending upon site configuration, but out-of-the-box it was a problem for administrators on multi-site installs.

This change adds explicit processing of variations in remove_insecure_properties so that they won't get removed.

Trac ticket: [](

@dsas commented on PR #5013:

3 weeks ago

@ramonjd, sorry I've been afk. What's the next step here?

@ramonopoly commented on PR #5013:

3 weeks ago

Thanks for the ping! We're now looking for a core committer to give final review.

Though I think it might now be punted to 6.3.2 (?)

At any rate, I added it to the 6.3.x board a while back so it's on the radar.

#4 @isabel_brison
3 weeks ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56502:

Editor: Preserve block style variations when securing theme.

Adds the ability to process block style variations to the remove_insecure_properties function of theme json class.

Props dsas, ramonopoly.
Fixes #59108.

#5 @isabel_brison
3 weeks ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to 6.3.2
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version set to 6.3

Reopening for second committer review/committing to 6.3 release branch.

@isabel_brison commented on PR #5013:

3 weeks ago

Committed to trunk in r56502; leaving the PR open pending commit to the release branch.

Note: See TracTickets for help on using tickets.