Preserve block style variations when securing theme json

[dean]

I'd like to sync a GB PR that fixes an issue where block style variations are not preserved when securing theme json

GB PR: ​https://github.com/WordPress/gutenberg/pull/53466

Valid and safe block style variations were being removed by WP_Theme_JSON::remove_insecure_properties when securing the theme.json. When this was a problem varied depending upon site configuration, but out-of-the-box it was a problem for administrators on multi-site installs.

This change adds explicit processing of variations in remove_insecure_properties so that they won't get removed.

Trac ticket: [](https://core.trac.wordpress.org/ticket/59108)

@ramonjd, sorry I've been afk. What's the next step here?

Thanks for the ping! We're now looking for a core committer to give final review.

Though I think it might now be punted to 6.3.2 (?)

At any rate, I added it to the ​6.3.x board a while back so it's on the radar.

[isabel_brison]

In 56502:

Editor: Preserve block style variations when securing theme.

Adds the ability to process block style variations to the remove_insecure_properties function of theme json class.

Props dsas, ramonopoly.
Fixes #59108.

[isabel_brison]

Reopening for second committer review/committing to 6.3 release branch.

Committed to trunk in r56502; leaving the PR open pending commit to the release branch.

[joemcgill]

It would be good to get a performance analysis of the changes in r56502, but it looks good at first glance.

[dsas]

@joemcgill how do I go about wrangling that? Is there a particular method I should use?

[audrasjb]

Worth noting that the @since mention should be set to 6.3.2, not 6.3.1

I'll add a follow up commit to fix it, then I will backport it to branch 6.3.

We still have one week before the final release to revert it if any performance issue is pointed out :)

[audrasjb]

In 56778:

Editor: Fix wrong @since mention in remove_insecure_properties().

Follow-up to [56502].

See #59108.

[audrasjb]

In 56779:

Editor: Preserve block style variations when securing theme.

Adds the ability to process block style variations to the remove_insecure_properties function of theme json class.

Props dsas, ramonopoly, dean, isabel_brison, joemcgill, audrasjb.
Merges [56502] and [56778] to the 6.3 branch.
Fixes #59108.