WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#59145 closed defect (bug) (fixed)

Revert the last instance of str_starts_with() in update-core.php

Reported by: azaozz Owned by: azaozz
Priority: normal Milestone: 6.3.1
Component: General Version: 6.3
Severity: normal Keywords: has-patch fixed-major dev-reviewed commit
Cc: Focuses:

Description

Follow-up to: https://core.trac.wordpress.org/ticket/58206#comment:64 by @frankit.

I might be wrong but I just commented on the github commit that it looks to me that str_starts_with() on line 1429 has been left over.

I'm getting Fatal error: Uncaught Error: Call to undefined function str_starts_with() [...] from that line while trying to update from a wp < 5.7 to latest 6.3

Change History (7)

#2 @azaozz
3 years ago

  • Owner set to azaozz
  • Resolution → fixed
  • Status new → closed

In 56417:

Revert the last use of str_starts_with() in update-core.php.

Fixes updating WordPress from 5.7 and earlier versions. When doing the update this file runs first in the old version where the polifills may not be available.

Porps: frankit.
Fixes: #59145.

#3 @azaozz
3 years ago

  • Resolution fixed
  • Status closed → reopened

Reopen for 6.3.1 consideration.

#4 @azaozz
3 years ago

  • Keywords has-patch fixed-major added

#5 @audrasjb
3 years ago

Looks good to me.
Marking as dev-reviewed and backporting right now.

#6 @audrasjb
3 years ago

  • Keywords dev-reviewed commit added

#7 @audrasjb
3 years ago

  • Resolution → fixed
  • Status reopened → closed

In 56425:

General: Revert the last use of str_starts_with() in update-core.php.

Fixes updating WordPress from 5.7 and earlier versions. When doing the update this file runs first in the old version where the polifills may not be available.

Props frankit, azaozz.
Reviewed by audrasjb.
Merges [56417] to the 6.3 branch.
Fixes #59145.

Note: See TracTickets for help on using tickets.