Make WordPress Core

Opened 3 years ago

Last modified 4 months ago

#59692 new defect (bug)

Twenty Fifteen theme having multiple issue with pullquote block.

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Steps to reproduce the issue:-

  1. Activate Twenty Fifteen theme.
  2. Choose PullQuote block.
  3. Apply some border with color

You can able to see that applied color is only seen in editor side front side border remains same.
If you have applied the text color then border takes that same color front side.

Issue 2:-
Now Change Font size.
You can able to see there is no change in font size both the side.

I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/tK1tywrx33bQgLRBD3z0

Attachments (2)

59692.patch (1.5 KB) - added by nidhidhandhukiya 3 years ago.
The patch will resolve the font-size related issue both the side.
59692.border-classes.patch (2.2 KB) - added by sabernhardt 4 months ago.
adds classes to front end for borders using theme's preset colors

Download all attachments as: .zip

Change History (10)

@nidhidhandhukiya
3 years ago

The patch will resolve the font-size related issue both the side.

#1 @ashikur698
3 years ago

Steps to reproduce the issue:-

  1. Activate Twenty Fifteen theme.
  2. Choose PullQuote block.
  3. Apply some border with color

It recrates the same issue. But there seems to be an issue with the appearance also.

Though there are many options like semi-bold, medium, italic etc. it seems only two things get applied no matter what I choose. It's either normal, or bold. No variation of bold/normal either.
Here's the link of that - https://monosnap.com/file/qjBr97FX5tQ7MRrL8G43KldMRlrwKb

I don't know if it fits for a separate ticket. That's why posting it here.

Last edited 3 years ago by ashikur698 (previous) (diff)

#2 @ravipatel
3 years ago

#59713 was marked as a duplicate.

#3 @karmatosed
2 years ago

  • Keywords has-patch needs-testing added

#4 @karmatosed
23 months ago

  • Milestone changed from Awaiting Review to Future Release

#5 @karmatosed
22 months ago

  • Keywords changes-requested added

The issue with this seems to be unfortunately the patch leaves no default font size unless I am mistaken now. I think we both need some testing to confirm this and a solution which both solves the issue and doesn't cause further visual problems. I am therefore going to suggest we look at iterating this patch, thank you everyone.

#6 @karmatosed
22 months ago

  • Keywords needs-testing removed

#7 @poena
9 months ago

#63705 was marked as a duplicate.

@sabernhardt
4 months ago

adds classes to front end for borders using theme's preset colors

#8 @sabernhardt
4 months ago

  • Keywords changes-requested removed

GB11610 started to deprecate the Pullquote block for WordPress 7.0, so I do not recommend trying to fix the custom font size issue now for that block. The following CSS worked for me, but then the line-height of 1.8182 could be too large.

.wp-block-pullquote:where([class*="-font-size"], [style*="font-size"]) blockquote {
	font-size: 1em;
}

However, adding classes for border colors in the theme's color palette is a simpler change, and it could help in other blocks later (#63072).

Note: See TracTickets for help on using tickets.