Context Navigation

← Previous Ticket
Next Ticket →

#59785 new defect (bug)

Fatal error: Attempt to assign property “object_id” on bool in class-wp-term-query.php

Reported by:	Faar	Owned by:
Priority:	normal	Milestone:	Awaiting Review
Component:	Taxonomy	Version:	6.3.3
Severity:	normal	Keywords:
Cc:		Focuses:

Description

The populate_terms() function in this class still throws a PHP fatal error on the get_term() query. Why?
In special circumstances, get_term() returns NULL and the variable $term is not checked to see if it is still an object or already boolean.
$term = NULL and this leads to a fatal PHP error and the page loading is aborted because $term->object_id does not work with NULL.
NULL->object_id

More to read here:
https://wordpress.org/support/topic/fatal-error-attempt-to-assign-property-object_id-on-bool/

Attachments (1)

59785-fix-fatal-error-attempt-to-assign-property-object_id-on-bool.diff (682 bytes ) - added by gliautard 2 years ago.: Hello, I can confirm this solved a problem we had on a multisite instance. Thanks!

Download all attachments as: .zip

Change History (5)

#1 @Faar
3 years ago

This solved the Error:

<?php
        protected function populate_terms( $terms ) {
                $term_objects = array();
                if ( ! is_array( $terms ) ) {
                        return $term_objects;
                }

                foreach ( $terms as $key => $term_data ) {
                        if ( is_object( $term_data ) && property_exists( $term_data, 'term_id' ) ) {
                                $term = get_term( $term_data->term_id );
                                if ( is_object( $term ) && property_exists( $term_data, 'object_id' ) ) { // modfied 2023_10_26 Faar: is_object()
               $term->object_id = (int) $term_data->object_id;
                                }
                                if ( property_exists( $term_data, 'count' ) ) {
                                        $term->count = (int) $term_data->count;
                                }
                        } else {
                                $term = get_term( $term_data );
                        }

                        if ( $term instanceof WP_Term ) {
                                $term_objects[ $key ] = $term;
                        }
                }

                return $term_objects;
        }

Asking, if is object $term.

@gliautard
2 years ago

Attachment 59785-fix-fatal-error-attempt-to-assign-property-object_id-on-bool.diff added

Hello, I can confirm this solved a problem we had on a multisite instance. Thanks!

#2 @robinmartijn
20 months ago

I can also confirm that it fixed the issue for us as well (in 6.6.2). What do we need to do to get this into core ASAP?

This ticket was mentioned in Slack in #core by robinmartijn. View the logs.

20 months ago

#4 @liamsputnik
12 months ago

Is there any indication when this fix is going to be merged?
It seems its not had any activity for a while.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core