WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#59825 closed enhancement (fixed)

Add unit tests for wp_checkdate

Reported by: pbearne Owned by: jorbin
Priority: normal Milestone: 6.5
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch has-unit-tests commit
Cc: Focuses:

Description


Change History (8)

This ticket was mentioned in ​PR #5630 on ​WordPress/wordpress-develop by ​@pbearne.
3 years ago #1

  • Keywords has-patch has-unit-tests added

​@ironprogrammer commented on ​PR #5630:
3 years ago #2

Thanks for the PR, @pbearne! 🙌🏻

I've created ​https://github.com/pbearne/wordpress-develop/pull/87 to collaborate on this. I'm happy to discuss the suggested changes, just lmk.

#3 @ironprogrammer
3 years ago

  • Milestone Awaiting Review → 6.5
  • Summary test for wp_checkdate → Add unit tests for wp_checkdate
  • Type defect (bug) → enhancement

#4 @ironprogrammer
3 years ago

  • Keywords commit added

This PR has been reviewed and approved, so marking for commit consideration during 6.5 cycle.

#5 @jorbin
3 years ago

  • Owner set to jorbin
  • Resolution → fixed
  • Status new → closed

In 57182:

Build/Test: Add unit tests for wp_checkdate.

Props pbearne, ironprogrammer.
Fixes #59825.

#6 @SergeyBiryukov
3 years ago

In 57183:

Tests: Revert [57182] from the 6.4 branch.

This will be committed to trunk instead.

See #59825.

#7 @SergeyBiryukov
3 years ago

In 57184:

Tests: Add unit tests for wp_checkdate().

Follow-up to [21922].

Props pbearne, ironprogrammer, antonvlasenko, SergeyBiryukov.
Fixes #59825.

​@SergeyBiryukov commented on ​PR #5630:
3 years ago #8

Thanks for the PR! Merged in r57184.

Note: See TracTickets for help on using tickets.