Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#59830 closed defect (bug) (fixed)

Administration: Typos in `wp_admin_notice()` arguments

Reported by: dlh's profile dlh Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.4.1 Priority: normal
Severity: normal Version: 6.4
Component: Administration Keywords: has-patch fixed-major dev-reviewed commit
Focuses: Cc:

Description

A few of the calls to the new wp_admin_notice() function appear to have typos in their argument arrays:

  • Two instances of additonal_classes instead of additional.
  • One instance of is-dismissible instead of dismissible.

Two of these three seem pretty unlikely to be encountered by most users in their daily work, but one of the instances of additonal occurs in update_nag(), making the notification for updating core appear somewhat diminished.

Attachments (1)

Screenshot 2023-11-08 at 12.17.06 AM.png (42.8 KB) - added by dlh 6 months ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in PR #5633 on WordPress/wordpress-develop by dlh01.


6 months ago
#1

  • Keywords has-patch added

#2 @mukesh27
6 months ago

  • Milestone changed from Awaiting Review to 6.4.1

Good catch, introduced in [56599] / #57791.

@mukesh27 commented on PR #5633:


6 months ago
#3

Patch working fine:
https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/10103365/b7a3496a-7b33-43a2-9058-b9838f408733

@sumitbagthariya16 commented on PR #5633:


6 months ago
#4

Patch is working as expected.

Before:
https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/67687255/ceda3e56-d0b6-4323-ade0-6d0be8ee4a2b

After:
https://i0.wp.com/github.com/WordPress/wordpress-develop/assets/67687255/5633e41c-e61f-44da-bab1-511d37af5a0b

#5 @SergeyBiryukov
6 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57084:

Administration: Fix typos in wp_admin_notice() arguments in a few instances.

Follow-up to [56570], [56599].

Props dlh, mukesh27, sumitbagthariya16.
Fixes #59830.

@SergeyBiryukov commented on PR #5633:


6 months ago
#6

Thanks for the PR! Merged in r57084.

#7 @SergeyBiryukov
6 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 6.4 branch.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


6 months ago

#9 @azaozz
6 months ago

  • Keywords dev-reviewed commit added

+1 to backport.

#10 @hellofromTonya
6 months ago

I'm also +1 for backporting to the 6.4 branch.

#11 @jorbin
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57087:

Administration: Fix typos in wp_admin_notice() arguments in a few instances.

Follow-up to [56570], [56599].

Reviewed by azaozz, joedolson, jorbin.

Props dlh, mukesh27, sumitbagthariya16.
Fixes #59830.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


6 months ago

#13 @rajinsharwar
6 months ago

#59857 was marked as a duplicate.

#14 @pbiron
6 months ago

#59895 was marked as a duplicate.

Note: See TracTickets for help on using tickets.