Make WordPress Core

Opened 17 months ago

Last modified 18 hours ago

#60336 new defect (bug)

Twenty Sixteen: Table block having issue with border when text color is used.

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 6.4.2
Component: Bundled Theme Keywords: has-patch has-test-info changes-requested
Focuses: Cc:

Description

Steps to reproduced the issue :-

  1. Activate Twenty Sixteen theme.
  2. Choose table block.
  3. Add some text.
  4. Apply text color.

Now you can able to see that the choosen text color also applied on border in editor side but in the user side the border color remains same as default border color.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/LJlVp3460bvvl5ZYRTsP

Attachments (2)

60336.patch (755 bytes) - added by nidhidhandhukiya 17 months ago.
Screenshot 2024-02-01 at 9.03.18 PM.png (189.6 KB) - added by deepakvijayan 17 months ago.

Download all attachments as: .zip

Change History (15)

#1 @huzaifaalmesbah
17 months ago

  • Keywords has-patch has-testing-info needs-testing added

#2 @deepakvijayan
17 months ago

Thanks for your work on this patch.

I've tested the patch, and it appears to be working as intended on my end. Attaching a screenshot of the same.

Environment

  • WordPress: 6.4.3
  • PHP: 7.4.33
  • Server: Apache/2.4.54 (Unix) OpenSSL/1.0.2u PHP/7.4.33 mod_wsgi/3.5 Python/2.7.18 mod_fastcgi/mod_fastcgi-SNAP-0910052141 mod_perl/2.0.11 Perl/v5.30.1
  • Database: mysqli (Server: 5.7.39 / Client: mysqlnd 7.4.33)
  • Browser: Chrome 121.0.0.0 (macOS)
  • Theme: Twenty Sixteen 3.1
  • MU-Plugins: None activated
  • Plugins:
    • WordPress Beta Tester 3.5.5

#3 @darshitrajyaguru97
16 months ago

Testing Report for: https://core.trac.wordpress.org/attachment/ticket/60336/60336.patch

Environment:


PHP: 8.1.9
WordPress: 6.4.3
Theme: Twenty Sixteen
Browser: Chrome
Plugin: No plugins


Before Patch Screenshot:
Backend: https://prnt.sc/xW62ZwC-rnox
Frontend: https://prnt.sc/0TqB0D2gLTgB


After Patch Screenshot:
Backend: https://prnt.sc/xW62ZwC-rnox
Frontend: https://prnt.sc/NLy4wPuQ_UKn


✅ Issue resolved with a patch.

#4 @poena
16 months ago

Edit: I did not apply the patch correctly. Here is my updated test report.

Testing Report for: https://core.trac.wordpress.org/attachment/ticket/60336/60336.patch

Environment

  • WordPress: 6.4.3
  • PHP: 8.1.23
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
  • Browser: Chrome 121.0.0.0
  • OS: macOS
  • Theme: Twenty Sixteen 3.1
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ❌ The table block that does not have a text color set (the default block as it is inserted), has the wrong border styles on the front. The default needs to be unchanged.
  2. ✅ The table block that has a text color shows the correct border styles in the editor and front.
Last edited 16 months ago by poena (previous) (diff)

#5 follow-up: @poena
16 months ago

There is another bug that is not mentioned in the ticket description:
Before the patch, the border color in the editor and front does not match, even when the user does not select a text color.
So it would be good to fix that bug, too. -The editor should match the color that is the default color on the front.

#6 in reply to: ↑ 5 @sunil25393
16 months ago

Replying to poena:

There is another bug that is not mentioned in the ticket description:
Before the patch, the border color in the editor and front does not match, even when the user does not select a text color.
So it would be good to fix that bug, too. -The editor should match the color that is the default color on the front.

@poena I have tested it with patch, and it does fix table default color issue too.

#7 @poena
16 months ago

Hi

@poena I have tested it with patch, and it does fix table default color issue too.

The color of the border in both the editor and front should be #d1d1d1 unless the user changes the text color.
The colors should not only match: the table needs to keep the original color that is part of the theme design. The patch removes the color.

That is what I meant by "The default needs to be unchanged." and "The editor should match the color that is the default color on the front."

Last edited 16 months ago by poena (previous) (diff)

#8 @karmatosed
15 months ago

  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to Future Release

If I am to understand correctly whilst this patch does resolve the issue there is a recommendation on improving it. It would be great to see that added so we can progress this for everyone, thank you.

#9 @karmatosed
11 months ago

  • Keywords needs-testing removed

#10 @wordpressdotorg
6 weeks ago

  • Keywords has-test-info added; has-testing-info removed

#11 @sabernhardt
5 days ago

#63604 was marked as a duplicate.

#12 @sabernhardt
5 days ago

  • Summary changed from Twenty Sixteen :- Table block having issue with border when text color is used. to Twenty Sixteen: Table block having issue with border when text color is used.

This ticket was mentioned in PR #9058 on WordPress/wordpress-develop by @sandeepdahiya.


18 hours ago
#13

Trac ticket: https://core.trac.wordpress.org/ticket/60336

Tables with custom text color now have matching borders on the frontend— by aligning border-color with currentColor. This creates a more cohesive and visually consistent block editor experience while preserving the default #d1d1d1 fallback when no custom color is set.

After patch when color is applied to text - backend and front end
https://github.com/user-attachments/assets/1721fd2d-1b96-4b6a-95a9-3870ee3b6138

After patch when no color is applied to text - border color is theme default color #d1d1d1
https://github.com/user-attachments/assets/9b74cd20-2831-4e04-97f5-2a39a1e53e65

Note: See TracTickets for help on using tickets.