Make WordPress Core

Opened 4 months ago

Last modified 6 weeks ago

#60336 new defect (bug)

Twenty Sixteen :- Table block having issue with border when text color is used.

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 6.4.2
Component: Bundled Theme Keywords: has-patch has-testing-info needs-testing changes-requested
Focuses: Cc:

Description

Steps to reproduced the issue :-

  1. Activate Twenty Sixteen theme.
  2. Choose table block.
  3. Add some text.
  4. Apply text color.

Now you can able to see that the choosen text color also applied on border in editor side but in the user side the border color remains same as default border color.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/LJlVp3460bvvl5ZYRTsP

Attachments (2)

60336.patch (755 bytes) - added by nidhidhandhukiya 4 months ago.
Screenshot 2024-02-01 at 9.03.18 PM.png (189.6 KB) - added by deepakvijayan 4 months ago.

Download all attachments as: .zip

Change History (10)

#1 @huzaifaalmesbah
4 months ago

  • Keywords has-patch has-testing-info needs-testing added

#2 @deepakvijayan
4 months ago

Thanks for your work on this patch.

I've tested the patch, and it appears to be working as intended on my end. Attaching a screenshot of the same.

Environment

  • WordPress: 6.4.3
  • PHP: 7.4.33
  • Server: Apache/2.4.54 (Unix) OpenSSL/1.0.2u PHP/7.4.33 mod_wsgi/3.5 Python/2.7.18 mod_fastcgi/mod_fastcgi-SNAP-0910052141 mod_perl/2.0.11 Perl/v5.30.1
  • Database: mysqli (Server: 5.7.39 / Client: mysqlnd 7.4.33)
  • Browser: Chrome 121.0.0.0 (macOS)
  • Theme: Twenty Sixteen 3.1
  • MU-Plugins: None activated
  • Plugins:
    • WordPress Beta Tester 3.5.5

#3 @darshitrajyaguru97
3 months ago

Testing Report for: https://core.trac.wordpress.org/attachment/ticket/60336/60336.patch

Environment:


PHP: 8.1.9
WordPress: 6.4.3
Theme: Twenty Sixteen
Browser: Chrome
Plugin: No plugins


Before Patch Screenshot:
Backend: https://prnt.sc/xW62ZwC-rnox
Frontend: https://prnt.sc/0TqB0D2gLTgB


After Patch Screenshot:
Backend: https://prnt.sc/xW62ZwC-rnox
Frontend: https://prnt.sc/NLy4wPuQ_UKn


✅ Issue resolved with a patch.

#4 @poena
3 months ago

Edit: I did not apply the patch correctly. Here is my updated test report.

Testing Report for: https://core.trac.wordpress.org/attachment/ticket/60336/60336.patch

Environment

  • WordPress: 6.4.3
  • PHP: 8.1.23
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
  • Browser: Chrome 121.0.0.0
  • OS: macOS
  • Theme: Twenty Sixteen 3.1
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.1.0

Actual Results

  1. ❌ The table block that does not have a text color set (the default block as it is inserted), has the wrong border styles on the front. The default needs to be unchanged.
  2. ✅ The table block that has a text color shows the correct border styles in the editor and front.
Last edited 3 months ago by poena (previous) (diff)

#5 follow-up: @poena
3 months ago

There is another bug that is not mentioned in the ticket description:
Before the patch, the border color in the editor and front does not match, even when the user does not select a text color.
So it would be good to fix that bug, too. -The editor should match the color that is the default color on the front.

#6 in reply to: ↑ 5 @sunil25393
3 months ago

Replying to poena:

There is another bug that is not mentioned in the ticket description:
Before the patch, the border color in the editor and front does not match, even when the user does not select a text color.
So it would be good to fix that bug, too. -The editor should match the color that is the default color on the front.

@poena I have tested it with patch, and it does fix table default color issue too.

#7 @poena
3 months ago

Hi

@poena I have tested it with patch, and it does fix table default color issue too.

The color of the border in both the editor and front should be #d1d1d1 unless the user changes the text color.
The colors should not only match: the table needs to keep the original color that is part of the theme design. The patch removes the color.

That is what I meant by "The default needs to be unchanged." and "The editor should match the color that is the default color on the front."

Last edited 3 months ago by poena (previous) (diff)

#8 @karmatosed
6 weeks ago

  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to Future Release

If I am to understand correctly whilst this patch does resolve the issue there is a recommendation on improving it. It would be great to see that added so we can progress this for everyone, thank you.

Note: See TracTickets for help on using tickets.