Opened 22 months ago
Closed 22 months ago
#60477 closed defect (bug) (wontfix)
Remove commented out code in wp-includes
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | General | Keywords: | |
| Focuses: | coding-standards | Cc: |
Description
Hello
I have reviewed core files and found that a few files still contain comments code that is not in use.
But as per the coding standard needs to be removed it from the files.
Files:
wp-includes/class-wp-query.php
wp-includes/rss.php
wp-includes/functions.wp-styles.php src/wp-includes/functions.wp-styles.php
wp-includes/sodium_compat/src/Compat.php
Attachments (1)
Change History (3)
#1
@
22 months ago
- Summary changed from Remove unused comments code from the wp-include files to Remove commented out code in wp-includes
Can you elaborate on the changes to src/wp-includes/class-wp-query.php and src/wp-includes/functions.wp-styles.php in your patch? Those a legit comments, not commented out code.
#2
@
22 months ago
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
Yes, the class-wp-query.php and functions.wp-styles.php comments are legitimate and need to stay.
- Since [4956], WP query has had a pair of comments to indicate where the
is_*correction begins and ends. - [4105] added the short note about fixing the call from
wp_head(ticket:2701#comment:19). - The
rss.phpfile is the deprecated MagpieRSS external library, and #57107 might remove the library's code. If not, #59548 already suggested similar edits. - To suggest any revisions to the sodium_compat external library, you could visit https://github.com/paragonie/sodium_compat
Note: See
TracTickets for help on using
tickets.
Applied a patch