Make WordPress Core

Opened 8 weeks ago

Last modified 8 weeks ago

#60554 assigned enhancement

Add support for using only PHP translation files

Reported by: swissspidy's profile swissspidy Owned by: swissspidy's profile swissspidy
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.5
Component: I18N Keywords: has-patch has-unit-tests
Focuses: Cc:

Description (last modified by swissspidy)

In WordPress 6.5 we're adding support for PHP translation files. They still require accompanying .mo and .po files. However, it doesn't have to be this way!

It should be possible for projects (plugins, themes, and core) to only use .l10n.php files.

A few areas that would need changing:

wp_get_installed_translations()

wp_get_installed_translations() is used for getting the list of installed translations for plugins/themes/core when updating language packs and also when uninstalling plugins/themes (to remove the translations again).

Language_Pack_Upgrader

\Language_Pack_Upgrader::check_package() checks whether there are .mo and .po in the language pack. It should also support language packs with only a .l10n.php file.

load_textdomain() / load_default_textdomain()

Not sure about this one.

Right now you can pass an .mo file path, even though the file doesn't exist, and WordPress will load the .l10n.php counterpart. So technically no change is required. However, what if you want to directly pass an .l10n.php file path instead?

Change History (2)

#1 @swissspidy
8 weeks ago

  • Description modified (diff)

This ticket was mentioned in PR #6129 on WordPress/wordpress-develop by @swissspidy.


8 weeks ago
#2

  • Keywords has-patch has-unit-tests added
  1. Scan for PHP files in wp_get_installed_translations(). So if only a PHP translation file exists, updates still work as expected. Also has the benefit of using $wp_textdomain_registry->get_language_files_from_path() instead of scandir, so the initial file list is cached.
  2. Support language packs that contain only PHP translation files but no mo/po.

Trac ticket: https://core.trac.wordpress.org/ticket/60554

Note: See TracTickets for help on using tickets.